From: Cornelia Huck <cohuck@redhat.com>
To: Tony Krowiak <akrowiak@linux.vnet.ibm.com>
Cc: Pierre Morel <pmorel@linux.vnet.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, borntraeger@de.ibm.com,
kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com,
pbonzini@redhat.com, alex.williamson@redhat.com,
alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com,
jjherne@linux.vnet.ibm.com, thuth@redhat.com,
pasic@linux.vnet.ibm.com, berrange@redhat.com,
fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com
Subject: Re: [PATCH v3 05/14] s390: vfio-ap: base implementation of VFIO AP device driver
Date: Tue, 27 Mar 2018 13:17:05 +0200 [thread overview]
Message-ID: <20180327131705.46fded40.cohuck@redhat.com> (raw)
In-Reply-To: <e4d7621c-a09c-bdfd-ffe2-35c5ea3acdc7@linux.vnet.ibm.com>
On Thu, 15 Mar 2018 13:25:25 -0400
Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:
> On 03/15/2018 09:25 AM, Pierre Morel wrote:
> > On 14/03/2018 19:25, Tony Krowiak wrote:
> >> +config VFIO_AP
> >> + def_tristate m
> > not sure it must be module by default.
> > I would not set it by default.
> Connie also asked about this in the last review, so I will go ahead
> and change it.
> >
> >> + prompt "VFIO support for AP devices"
> >> + depends on ZCRYPT && VFIO_MDEV_DEVICE
> >
> > VFIO_MDEV_DEVICE is a general feature *needed* by VFIO_AP
> > and has no use case by its own. If it is set it is obviously because some
> > mediated device drivers needs it.
> > while ZCRYPT is a Z feature which may be set without VFIO_AP.
> >
> > So you need:
> >
> > config VFIO_AP
> > def_tristate n
> > prompt "VFIO support for AP devices"
> > depends on ZCRYPT
> > select VFIO_MDEV
> > select VFIO_MDEV_DEVICE
> > ...
> I was thinking the same just yesterday and I agree, this makes sense.
OTOH, nobody else seems to do a select on these symbols so far.
If you decide to go that route, you'll also need to depend on VFIO
(otherwise you could end up selecting symbols with unmet dependencies).
All in all, I prefer the 'depends' approach.
next prev parent reply other threads:[~2018-03-27 11:17 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 18:25 [PATCH v3 00/14] s390: vfio-ap: guest dedicated crypto adapters Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 01/14] KVM: s390: refactor crypto initialization Tony Krowiak
2018-03-15 12:26 ` Pierre Morel
2018-03-15 14:48 ` Tony Krowiak
2018-03-15 14:55 ` Pierre Morel
2018-03-26 8:44 ` Cornelia Huck
2018-03-29 18:57 ` Tony Krowiak
2018-04-03 11:26 ` Cornelia Huck
2018-04-05 10:42 ` Christian Borntraeger
2018-04-05 10:45 ` Christian Borntraeger
2018-04-05 13:16 ` Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 02/14] s390: zcrypt: externalize AP instructions available function Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 03/14] KVM: s390: CPU model support for AP virtualization Tony Krowiak
2018-03-27 10:59 ` Cornelia Huck
2018-03-27 11:22 ` Pierre Morel
2018-03-27 11:30 ` Cornelia Huck
2018-03-14 18:25 ` [PATCH v3 04/14] KVM: s390: device attribute to set AP interpretive execution Tony Krowiak
2018-03-14 21:57 ` Halil Pasic
2018-03-15 13:00 ` Pierre Morel
2018-03-15 15:26 ` Tony Krowiak
2018-03-15 15:45 ` Pierre Morel
2018-03-15 17:21 ` Tony Krowiak
2018-03-15 17:56 ` Pierre Morel
2018-03-15 23:39 ` Tony Krowiak
2018-03-16 7:51 ` Pierre Morel
2018-03-16 16:09 ` Tony Krowiak
2018-03-20 17:58 ` Tony Krowiak
2018-03-20 22:48 ` Halil Pasic
2018-04-02 18:55 ` Tony Krowiak
2018-03-15 15:23 ` Tony Krowiak
2018-03-15 16:00 ` Pierre Morel
2018-03-15 23:37 ` Tony Krowiak
2018-03-15 16:25 ` Halil Pasic
2018-03-14 18:25 ` [PATCH v3 05/14] s390: vfio-ap: base implementation of VFIO AP device driver Tony Krowiak
2018-03-15 13:25 ` Pierre Morel
2018-03-15 17:25 ` Tony Krowiak
2018-03-27 11:17 ` Cornelia Huck [this message]
2018-03-27 14:45 ` Pierre Morel
2018-04-03 9:56 ` Cornelia Huck
2018-04-03 10:57 ` Cornelia Huck
2018-04-03 13:02 ` Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 06/14] s390: vfio-ap: register matrix device with VFIO mdev framework Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 07/14] KVM: s390: interfaces to configure/deconfigure guest's AP matrix Tony Krowiak
2018-04-03 11:07 ` Cornelia Huck
2018-04-03 13:17 ` Tony Krowiak
2018-04-03 13:38 ` Cornelia Huck
2018-03-14 18:25 ` [PATCH v3 08/14] s390: vfio-ap: sysfs interfaces to configure adapters Tony Krowiak
2018-04-03 11:10 ` Cornelia Huck
2018-04-03 13:33 ` Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 09/14] s390: vfio-ap: sysfs interfaces to configure domains Tony Krowiak
2018-04-03 11:17 ` Cornelia Huck
[not found] ` <1860430c-df59-6d58-77f9-b36c51595b4b@linux.vnet.ibm.com>
2018-04-03 15:19 ` Cornelia Huck
2018-04-03 15:42 ` Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 10/14] s390: vfio-ap: sysfs interfaces to configure control domains Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 11/14] s390: vfio-ap: sysfs interface to view matrix mdev matrix Tony Krowiak
2018-03-15 9:42 ` Pierre Morel
2018-03-15 14:52 ` Tony Krowiak
2018-03-15 15:35 ` Pierre Morel
2018-03-27 11:19 ` Cornelia Huck
2018-03-14 18:25 ` [PATCH v3 12/14] KVM: s390: configure the guest's AP devices Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 13/14] s390: vfio-ap: implement VFIO_DEVICE_GET_INFO ioctl Tony Krowiak
2018-03-14 18:25 ` [PATCH v3 14/14] s390: doc: detailed specifications for AP virtualization Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327131705.46fded40.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=akrowiak@linux.vnet.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=berrange@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=buendgen@de.ibm.com \
--cc=fiuczy@linux.vnet.ibm.com \
--cc=freude@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).