From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbeC0Odn (ORCPT ); Tue, 27 Mar 2018 10:33:43 -0400 Received: from verein.lst.de ([213.95.11.211]:40625 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbeC0Odm (ORCPT ); Tue, 27 Mar 2018 10:33:42 -0400 Date: Tue, 27 Mar 2018 16:33:41 +0200 From: Christoph Hellwig To: Sebastian Ott Cc: Christoph Hellwig , Jesper Nilsson , Geert Uytterhoeven , linux-kernel@vger.kernel.org Subject: Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 Message-ID: <20180327143341.GA4968@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 27, 2018 at 10:12:54AM +0200, Sebastian Ott wrote: > Hi, > > commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma > allocations specifying __GFP_ZERO by silently removing that flag. > > Why should "the memory returned [] always be zeroed."? Because that is what the current implementations do - we always zero the memory returned from dma_map_ops.alloc().