From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1522180948; cv=none; d=google.com; s=arc-20160816; b=sHhV1tgbsQ1C02KR30Y+qh6mJ75uuqwbkyFOQcvmZbD+fxiHvYZktt+BmRVsy8mXKu U/Qv0ljdK20+8ueIVtDMm6v7a8M+raiCG/Y+yQqvZvVRZDeek5LlDOei4Vjl8Rl9c2og Ls2JIyb7eRU6MG2u2Y77xmDf/rRewMasQd6QkrKKZ13LYQVfd8rk8d62goYhVhWZXIeH F11+rcbeTSgExWg1OTRI5D1eAm/8CDC6QN5pV3JZA0G13z6ehqOLo63vLDeppyZl+0IT XfLFzOxpnT/V7APrjAPPC4h2fVQluf7T3s1jVO/aQoG3ZYexwJmDdvjrcdlsUwfuiqJJ BDpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:sender:dkim-signature:arc-authentication-results; bh=xP9hu6HCqyqwvJgWoQFZWWhzKoWYaLMIFOWPuqp0fo4=; b=R1wLVtxarwL3UtMstG2qVWCv47w/ws0YLL3AvK7OVswW62GEYRMszUsGojGZ3GJvn6 iC5W1WwfAKUhKbq1j9cKbnTDheE4/Ed4sJcUSAWe7XPvBvjhav9ivxYIJMwgojzlu/V5 +HGNgvfxXuwP8RAib08hYXFkKoFx/dDo5500n2WHeDG8xL9XCBsYmIm6aYSjYx2X95Pq 9jUYeY39gRXBxflybD+4F1Z3mk9RfqZSEfJFteCaIorCk+A4EjkmJFx6Ew8JYRhOmj50 nvIjTnjdNM9h+NRKn3ejIoJOIzBMnsZRGfGyxJlJE9lm+4fwKtdgLRQKdwOadK2NYGkq urxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vM8dX7/8; spf=pass (google.com: domain of mingo.kernel.org@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vM8dX7/8; spf=pass (google.com: domain of mingo.kernel.org@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com X-Google-Smtp-Source: AIpwx4+VmzwoR9XzOhauPxy6VNdugboOYl6dZ4CBHT0qgQnYelgsxzZcZ52Y+adDRTVQG4HfSooHwg== Sender: Ingo Molnar Date: Tue, 27 Mar 2018 22:02:23 +0200 From: Ingo Molnar To: Andrey Konovalov Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Jonathan Corbet , Catalin Marinas , Will Deacon , Christoffer Dall , Marc Zyngier , Christopher Li , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Masahiro Yamada , Michal Marek , Mark Rutland , Ard Biesheuvel , Yury Norov , Nick Desaulniers , Suzuki K Poulose , Kristina Martsenko , Punit Agrawal , Dave Martin , Michael Weiser , James Morse , Julien Thierry , Steve Capper , Tyler Baicar , "Eric W . Biederman" , Stephen Boyd , Thomas Gleixner , Paul Lawrence , Greg Kroah-Hartman , David Woodhouse , Sandipan Das , Kees Cook , Herbert Xu , Geert Uytterhoeven , Josh Poimboeuf , Arnd Bergmann , kasan-dev , linux-doc@vger.kernel.org, LKML , Linux ARM , kvmarm@lists.cs.columbia.edu, linux-sparse@vger.kernel.org, Linux Memory Management List , Linux Kbuild mailing list , Kostya Serebryany , Evgeniy Stepanov , Lee Smith , Ramana Radhakrishnan , Jacob Bramley , Ruben Ayrapetyan , Kees Cook , Jann Horn , Mark Brand Subject: Re: [RFC PATCH v2 03/15] khwasan: add CONFIG_KASAN_CLASSIC and CONFIG_KASAN_TAGS Message-ID: <20180327200223.5ku2eqkppi7z3sd2@gmail.com> References: <1fb0a050a84d49f5c3b2210337339412475d1688.1521828273.git.andreyknvl@google.com> <20180324084332.u6qik7lkdbenqbb2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1595752701351251910?= X-GMAIL-MSGID: =?utf-8?q?1596122409839180075?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: * Andrey Konovalov wrote: > On Sat, Mar 24, 2018 at 9:43 AM, Ingo Molnar wrote: > > > > * Andrey Konovalov wrote: > > > >> This commit splits the current CONFIG_KASAN config option into two: > >> 1. CONFIG_KASAN_CLASSIC, that enables the classic KASAN version (the one > >> that exists now); > >> 2. CONFIG_KASAN_TAGS, that enables KHWASAN. > > > > Sorry, but this is pretty obscure naming scheme that doesn't explain the primary > > difference between these KASAN models to users: that the first one is a pure > > software implementation and the other is hardware-assisted. > > > > Reminds me of the transparency of galactic buerocracy in "The Hitchhiker's Guide > > to the Galaxy": > > > > “But look, you found the notice, didn’t you?” > > “Yes,” said Arthur, “yes I did. It was on display in the bottom of a locked filing > > cabinet stuck in a disused lavatory with a sign on the door saying ‘Beware of the > > Leopard.” > > > > I'd suggest something more expressive, such as: > > > > CONFIG_KASAN > > CONFIG_KASAN_GENERIC > > CONFIG_KASAN_HW_ASSIST > > > > or so? > > > > The 'generic' variant will basically run on any CPU. The 'hardware assisted' one > > needs support from the CPU. > > > > The following ones might also work: > > > > CONFIG_KASAN_HWASSIST > > CONFIG_KASAN_HW_TAGS > > CONFIG_KASAN_HWTAGS > > > > ... or simply CONFIG_KASAN_SW/CONFIG_KASAN_HW. > > > > If other types of KASAN hardware acceleration are implemented in the future then > > the CONFIG_KASAN_HW namespace can be extended: > > > > CONFIG_KASAN_HW_TAGS > > CONFIG_KASAN_HW_KEYS > > etc. > > How about these two: > > CONFIG_KASAN_GENERIC > CONFIG_KASAN_HW > > ? > > Shorter config name looks better to me and I think it makes sense to > name the new config just HW, as there's only one HW implementation > right now. When (and if) there are more, we can expand the config name > as you suggested (CONFIG_KASAN_HW_TAGS, CONFIG_KASAN_HW_KEYS, etc). Sure, sounds good to me! Thanks, Ingo