From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbeC1Hf7 (ORCPT ); Wed, 28 Mar 2018 03:35:59 -0400 Received: from mga14.intel.com ([192.55.52.115]:8808 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbeC1Hf5 (ORCPT ); Wed, 28 Mar 2018 03:35:57 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,370,1517904000"; d="scan'208";a="27635499" Date: Wed, 28 Mar 2018 15:26:31 +0800 From: "Du, Changbin" To: Arnaldo Carvalho de Melo Cc: "Du, Changbin" , jolsa@redhat.com, peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH] perf trace: remove redundant ')' Message-ID: <20180328072631.gj72odnaimsohkmc@intel.com> References: <1520937601-24952-1-git-send-email-changbin.du@intel.com> <20180316075108.xwenvklz3a6scodh@intel.com> <20180316125045.GC10026@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180316125045.GC10026@kernel.org> User-Agent: NeoMutt/20180323-6-5ca392 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, Just a kind reminder. Hope you didn't forget this. On Fri, Mar 16, 2018 at 09:50:45AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu: > > Hi Arnaldo, How about this simple one? Thanks. > > > > On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin.du@intel.com wrote: > > > From: Changbin Du > > > > > > There is a redundant ')' at the tail of each event. So remove it. > > > $ sudo perf trace --no-syscalls -e 'kmem:*' -a > > > 899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil)) > > > 899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil)) > > > > > > Signed-off-by: Changbin Du > > > --- > > > tools/perf/builtin-trace.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c > > > index e7f1b18..7273f5f 100644 > > > --- a/tools/perf/builtin-trace.c > > > +++ b/tools/perf/builtin-trace.c > > > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel, > > > trace->output); > > > } > > > > > > - fprintf(trace->output, ")\n"); > > > + fprintf(trace->output, "\n"); > > It looks simple on the surface, but I couldn't quickly recall why this > ')' was put there in the first place... So I left for later to do a 'git > blame' on this file, etc. > > - Arnaldo > > > > if (callchain_ret > 0) > > > trace__fprintf_callchain(trace, sample); > > > -- > > > 2.7.4 > > > > > > > -- > > Thanks, > > Changbin Du -- Thanks, Changbin Du