From: Michal Hocko <mhocko@kernel.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
Dave Chinner <david@fromorbit.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@lst.de>, xfs <linux-xfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
Sasha Levin <alexander.levin@microsoft.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Josh Triplett <josh@joshtriplett.org>,
Takashi Iwai <tiwai@suse.de>, Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH] xfs: always free inline data before resetting inode fork during ifree
Date: Wed, 28 Mar 2018 15:21:48 +0200 [thread overview]
Message-ID: <20180328132148.GN9275@dhcp22.suse.cz> (raw)
In-Reply-To: <20180327195435.GE9190@wotan.suse.de>
On Tue 27-03-18 19:54:35, Luis R. Rodriguez wrote:
> On Tue, Mar 27, 2018 at 09:06:37AM +0200, Michal Hocko wrote:
> > So by no means the MM backports were reviewed by me. And considering how hard
> > it is to get any review for MM patches in general I strongly suspect that
> > others didn't review either.
> >
> > In general I am quite skeptical about the automagic backports
> > selections, to be honest. MM patches should be reasonably good at
> > selecting stable backports and adding more patches on top just risks
> > regressions.
>
> BTW other than suggesting we needing *actual review* of the MM patches, are
> there known unit tests which could be run as well? Thinking long term.
There are some in selftests but most fixes are quite hard to get a
specialized testcase for. Rememeber the MM is a pile of heuristics to
handle large scale of workloads.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-03-28 13:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171123060137.GL2135@magnolia>
[not found] ` <20180323013037.GA9190@wotan.suse.de>
[not found] ` <20180323034145.GH4818@magnolia>
[not found] ` <20180323170813.GD30543@wotan.suse.de>
[not found] ` <20180323172620.GK4818@magnolia>
2018-03-23 18:23 ` [PATCH] xfs: always free inline data before resetting inode fork during ifree Luis R. Rodriguez
2018-03-24 9:06 ` Greg Kroah-Hartman
2018-03-24 17:21 ` Darrick J. Wong
2018-03-26 4:54 ` Sasha Levin
2018-03-26 6:48 ` Darrick J. Wong
2018-03-26 17:39 ` Luis R. Rodriguez
2018-03-25 22:33 ` Dave Chinner
2018-03-26 23:54 ` Sasha Levin
2018-03-27 7:06 ` Michal Hocko
2018-03-27 19:54 ` Luis R. Rodriguez
2018-03-28 13:21 ` Michal Hocko [this message]
2018-03-28 19:33 ` Sasha Levin
2018-03-29 7:01 ` Michal Hocko
2018-03-28 1:11 ` Sasha Levin
2018-03-28 13:20 ` Michal Hocko
2018-03-28 3:32 ` Dave Chinner
2018-03-28 19:30 ` Sasha Levin
2018-03-28 19:40 ` Darrick J. Wong
2018-03-28 23:05 ` Dave Chinner
2018-03-29 18:12 ` Luis R. Rodriguez
2018-03-29 18:17 ` Josef Bacik
2018-03-29 18:36 ` Sasha Levin
2018-03-30 2:47 ` Sasha Levin
2018-03-30 19:49 ` Luis R. Rodriguez
2018-04-02 0:35 ` Sasha Levin
2018-03-31 22:02 ` Dave Chinner
2018-04-02 0:32 ` Sasha Levin
2018-04-03 1:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328132148.GN9275@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=alexander.levin@microsoft.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=joro@8bytes.org \
--cc=josh@joshtriplett.org \
--cc=julia.lawall@lip6.fr \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).