Re: [PATCH 4.9 00/67] 4.9.91-stable review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Mar 28, 2018 at 10:50:35AM -0500, Dan Rue wrote:
> On Wed, Mar 28, 2018 at 10:21:45AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Mar 27, 2018 at 08:35:01PM -0500, Dan Rue wrote:
> > > qemu_x86_64
> > > * boot - pass: 21
> > > * kselftest - skip: 28, pass: 52
> > 
> > Do you have a list of what you are skipping anywhere?  There was some
> > x86 changes that I had to backport that I was worried about getting
> > right here, are you running the x86 kselftests?
> 
> Yes we run the x86 selftests. Here's the full list of what ran and what was
> skipped. Remember (I know you know, but for anyone else observing), we
> run kselftest from 4.15.

That's good, as kselftest from 4.9 was a bit broken for x86, which is
why I backported a bunch of patches for it for this release :)

>  breakpoint_test — SKIP
>  efivarfs.sh — SKIP
>  fsgsbase_64 — SKIP
>  ftracetest — SKIP
>  fw_fallback.sh — SKIP
>  fw_filesystem.sh — SKIP
>  gpio-mockup.sh — SKIP
>  ldt_gdt_64 — SKIP
>  main.sh — SKIP
>  mem-on-off-test.sh — SKIP
>  pstore_tests — SKIP
>  reuseport_bpf — SKIP
>  run.sh — SKIP
>  run_vmtests — SKIP
>  seccomp_bpf — SKIP
>  sigreturn_64 — SKIP
>  step_after_suspend_test — SKIP
>  sync_test — SKIP
>  sysctl.sh — SKIP
>  test_align — SKIP
>  test_dev_cgroup — SKIP
>  test_kmod.sh — SKIP
>  test_lpm_map — SKIP
>  test_lru_map — SKIP
>  test_maps — SKIP
>  test_progs — SKIP
>  test_tag — SKIP
>  test_verifier — SKIP

Figuring out of any of these are from the tools/testing/selftests/x86/
directory is a pain, that is the tests I was referring to here...

That being said, why are you skipping so many?  ldt_gdt_64 should be
run, what fails with it?  Same for sigreturn_64, which I think means
that only 2 tests from the x86 directory are being skipped, right?

Have you gone back and looked at any of those other tests to see why
they are being skipped?

thanks,

greg k-h