From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Scott Branden <scott.branden@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
Abhishek Shah <abhishek.shah@broadcom.com>,
Ray Jui <ray.jui@broadcom.com>,
linux-kernel@vger.kernel.org (open list),
jon.mason@broadcom.com, nbd@nbd.name
Subject: [PATCH net 1/2] net: bgmac: Correctly annotate register space
Date: Sun, 1 Apr 2018 10:26:29 -0700 [thread overview]
Message-ID: <20180401172630.12883-2-f.fainelli@gmail.com> (raw)
In-Reply-To: <20180401172630.12883-1-f.fainelli@gmail.com>
All the members: base, idm_base and nicpm_base should be annotated with
__iomem since they are pointers to register space. This fixes a bunch of
sparse reported warnings.
Fixes: f6a95a24957a ("net: ethernet: bgmac: Add platform device support")
Fixes: dd5c5d037f5e ("net: ethernet: bgmac: add NS2 support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/bgmac.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac.h b/drivers/net/ethernet/broadcom/bgmac.h
index 4040d846da8e..40d02fec2747 100644
--- a/drivers/net/ethernet/broadcom/bgmac.h
+++ b/drivers/net/ethernet/broadcom/bgmac.h
@@ -479,9 +479,9 @@ struct bgmac_rx_header {
struct bgmac {
union {
struct {
- void *base;
- void *idm_base;
- void *nicpm_base;
+ void __iomem *base;
+ void __iomem *idm_base;
+ void __iomem *nicpm_base;
} plat;
struct {
struct bcma_device *core;
--
2.14.1
next prev parent reply other threads:[~2018-04-01 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 17:26 [PATCH net 0/2] net: bgmac: Couple of sparse warnings Florian Fainelli
2018-04-01 17:26 ` Florian Fainelli [this message]
2018-04-01 17:26 ` [PATCH net 2/2] net: bgmac: Fix endian access in bgmac_dma_tx_ring_free() Florian Fainelli
2018-04-02 2:21 ` [PATCH net 0/2] net: bgmac: Couple of sparse warnings David Miller
2018-04-02 17:17 ` Florian Fainelli
2018-04-02 17:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180401172630.12883-2-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=abhishek.shah@broadcom.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jon.mason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).