From: Suman Anna <s-anna@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Dave Gerlach <d-gerlach@ti.com>, Tero Kristo <t-kristo@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Suman Anna <s-anna@ti.com>, Zumeng Chen <zumeng.chen@gmail.com>,
<stable@vger.kernel.org>
Subject: [PATCH v2 1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value
Date: Mon, 2 Apr 2018 11:49:57 -0500 [thread overview]
Message-ID: <20180402164958.20057-2-s-anna@ti.com> (raw)
In-Reply-To: <20180402164958.20057-1-s-anna@ti.com>
Commit 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when
failure") has fixed a memory leak in the failure path, however
the patch returned a positive value on get_cpu_device() failure
instead of the previous negative value. Fix this incorrect error
return value properly.
Fixes: 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure")
Cc: Zumeng Chen <zumeng.chen@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Suman Anna <s-anna@ti.com>
---
drivers/cpufreq/ti-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
index a099b7bf74cd..46d1ab2dea87 100644
--- a/drivers/cpufreq/ti-cpufreq.c
+++ b/drivers/cpufreq/ti-cpufreq.c
@@ -226,7 +226,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev)
opp_data->cpu_dev = get_cpu_device(0);
if (!opp_data->cpu_dev) {
pr_err("%s: Failed to get device for CPU0\n", __func__);
- ret = ENODEV;
+ ret = -ENODEV;
goto free_opp_data;
}
--
2.16.2
next prev parent reply other threads:[~2018-04-02 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 16:49 [PATCH v2 0/2] ti-cpufreq: minor fixes/cleanups Suman Anna
2018-04-02 16:49 ` Suman Anna [this message]
2018-04-03 4:20 ` [PATCH v2 1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value Viresh Kumar
2018-04-02 16:49 ` [PATCH v2 2/2] cpufreq: ti-cpufreq: Use devres managed API in probe() Suman Anna
2018-04-03 4:22 ` Viresh Kumar
2018-05-18 15:07 ` [PATCH v2 0/2] ti-cpufreq: minor fixes/cleanups Suman Anna
2018-05-18 20:19 ` Rafael J. Wysocki
2018-05-31 22:29 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402164958.20057-2-s-anna@ti.com \
--to=s-anna@ti.com \
--cc=d-gerlach@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
--cc=t-kristo@ti.com \
--cc=viresh.kumar@linaro.org \
--cc=zumeng.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).