From: Ladislav Michl <ladis@linux-mips.org>
To: Joe Perches <joe@perches.com>
Cc: Colin King <colin.king@canonical.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@microchip.com>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"
Date: Tue, 3 Apr 2018 20:54:23 +0200 [thread overview]
Message-ID: <20180403185423.GA8683@lenoch> (raw)
In-Reply-To: <1522779423.11653.63.camel@perches.com>
On Tue, Apr 03, 2018 at 11:17:03AM -0700, Joe Perches wrote:
> On Tue, 2018-04-03 at 19:30 +0200, Ladislav Michl wrote:
> > On Tue, Apr 03, 2018 at 08:49:57AM -0700, Joe Perches wrote:
> > > On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote:
> > > > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote:
> > > > > From: Colin Ian King <colin.king@canonical.com>
> > > >
> > > > Hello Colin,
> > > >
> > > > > Trivial fix to spelling mistake in pr_debug message text
> > > >
> > > > would you mind making this patch a bit less non-trivial and
> > > > change pr_debug to dev_dbg dropping Atmel_ssc_dai prefix?
> > >
> > > Presumably, then all the pr_<foo> calls should be changed.
> > Yes, that's what non-trivial means here :)
>
> More useful would be less specific originally.
>
> > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> []
> > > @@ -1050,21 +1047,18 @@ static void asoc_ssc_exit(struct device *dev)
> > > int atmel_ssc_set_audio(int ssc_id)
> > > {
> > > struct ssc_device *ssc;
> > > - int ret;
> > >
> > > /* If we can grab the SSC briefly to parent the DAI device off it */
> > > ssc = ssc_request(ssc_id);
> > > if (IS_ERR(ssc)) {
> > > pr_err("Unable to parent ASoC SSC DAI on SSC: %ld\n",
> > > - PTR_ERR(ssc));
> > > + PTR_ERR(ssc));
> >
> > Well, these are usefull, but unrelated changes. But while there, above
> > pr_error deserves to be replaced with dev_err as well.
>
> No dai device.
As all call sites are already providing error message, so what about just
removing this one completely?
next prev parent reply other threads:[~2018-04-03 18:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 15:44 [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping" Colin King
2018-03-31 8:54 ` Alexandre Belloni
2018-04-03 8:50 ` Nicolas Ferre
2018-04-03 13:45 ` [alsa-devel] " Ladislav Michl
2018-04-03 15:49 ` Joe Perches
2018-04-03 17:30 ` Ladislav Michl
2018-04-03 18:17 ` Joe Perches
2018-04-03 18:54 ` Ladislav Michl [this message]
2018-04-03 23:08 ` Joe Perches
2018-04-04 10:24 ` Dan Carpenter
2018-04-04 10:41 ` Colin Ian King
2018-04-04 12:30 ` Ladislav Michl
2018-04-04 14:46 ` Mark Brown
2018-04-12 16:16 ` Applied "ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"" to the asoc tree Mark Brown
2018-04-13 10:56 ` Mark Brown
2018-04-13 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403185423.GA8683@lenoch \
--to=ladis@linux-mips.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).