From: kbuild test robot <lkp@intel.com>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: kbuild-all@01.org, mhiramat@kernel.org, oleg@redhat.com,
peterz@infradead.org, srikar@linux.vnet.ibm.com,
rostedt@goodmis.org, acme@kernel.org, ananth@linux.vnet.ibm.com,
akpm@linux-foundation.org, alexander.shishkin@linux.intel.com,
alexis.berlemont@gmail.com, corbet@lwn.net,
dan.j.williams@intel.com, jolsa@redhat.com, kan.liang@intel.com,
kjlx@templeofstupid.com, kstewart@linuxfoundation.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, milian.wolff@kdab.com, mingo@redhat.com,
namhyung@kernel.org, naveen.n.rao@linux.vnet.ibm.com,
pc@us.ibm.com, tglx@linutronix.de, yao.jin@linux.intel.com,
fengguang.wu@intel.com, jglisse@redhat.com,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 7/9] trace_uprobe/sdt: Fix multiple update of same reference counter
Date: Wed, 4 Apr 2018 21:18:13 +0800 [thread overview]
Message-ID: <201804042112.fiyMtCnW%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180404083110.18647-8-ravi.bangoria@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2994 bytes --]
Hi Ravi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.16 next-20180403]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ravi-Bangoria/trace_uprobe-Support-SDT-markers-having-reference-count-semaphore/20180404-201900
config: x86_64-randconfig-x019-201813 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
>> kernel/trace/trace_uprobe.c:947:21: error: variable 'sdt_mmu_notifier_ops' has initializer but incomplete type
static const struct mmu_notifier_ops sdt_mmu_notifier_ops = {
^~~~~~~~~~~~~~~~
>> kernel/trace/trace_uprobe.c:948:3: error: 'const struct mmu_notifier_ops' has no member named 'release'
.release = sdt_mm_release,
^~~~~~~
>> kernel/trace/trace_uprobe.c:948:13: warning: excess elements in struct initializer
.release = sdt_mm_release,
^~~~~~~~~~~~~~
kernel/trace/trace_uprobe.c:948:13: note: (near initialization for 'sdt_mmu_notifier_ops')
kernel/trace/trace_uprobe.c: In function 'sdt_add_mm_list':
>> kernel/trace/trace_uprobe.c:962:22: error: dereferencing pointer to incomplete type 'struct mmu_notifier'
mn = kzalloc(sizeof(*mn), GFP_KERNEL);
^~~
>> kernel/trace/trace_uprobe.c:967:2: error: implicit declaration of function '__mmu_notifier_register'; did you mean 'mmu_notifier_release'? [-Werror=implicit-function-declaration]
__mmu_notifier_register(mn, mm);
^~~~~~~~~~~~~~~~~~~~~~~
mmu_notifier_release
kernel/trace/trace_uprobe.c: At top level:
>> kernel/trace/trace_uprobe.c:947:38: error: storage size of 'sdt_mmu_notifier_ops' isn't known
static const struct mmu_notifier_ops sdt_mmu_notifier_ops = {
^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/sdt_mmu_notifier_ops +947 kernel/trace/trace_uprobe.c
946
> 947 static const struct mmu_notifier_ops sdt_mmu_notifier_ops = {
> 948 .release = sdt_mm_release,
949 };
950
951 static void sdt_add_mm_list(struct trace_uprobe *tu, struct mm_struct *mm)
952 {
953 struct mmu_notifier *mn;
954 struct sdt_mm_list *sml = kzalloc(sizeof(*sml), GFP_KERNEL);
955
956 if (!sml)
957 return;
958 sml->mm = mm;
959 list_add(&(sml->list), &(tu->sml.list));
960
961 /* Register mmu_notifier for this mm. */
> 962 mn = kzalloc(sizeof(*mn), GFP_KERNEL);
963 if (!mn)
964 return;
965
966 mn->ops = &sdt_mmu_notifier_ops;
> 967 __mmu_notifier_register(mn, mm);
968 }
969
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26443 bytes --]
next prev parent reply other threads:[~2018-04-04 13:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 8:31 [PATCH v2 0/9] trace_uprobe: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-04-04 8:31 ` [PATCH v2 1/9] Uprobe: Export vaddr <-> offset conversion functions Ravi Bangoria
2018-04-04 8:31 ` [PATCH v2 2/9] mm: Prefix vma_ to vaddr_to_offset() and offset_to_vaddr() Ravi Bangoria
2018-04-04 8:31 ` [PATCH v2 3/9] Uprobe: Move mmput() into free_map_info() Ravi Bangoria
2018-04-04 8:31 ` [PATCH v2 4/9] Uprobe: Rename map_info to uprobe_map_info Ravi Bangoria
2018-04-04 8:31 ` [PATCH v2 5/9] Uprobe: Export uprobe_map_info along with uprobe_{build/free}_map_info() Ravi Bangoria
2018-04-04 8:31 ` [PATCH v2 6/9] trace_uprobe: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-04-04 15:03 ` [RFC PATCH] trace_uprobe: trace_uprobe_mmap() can be static kbuild test robot
2018-04-04 15:03 ` [PATCH v2 6/9] trace_uprobe: Support SDT markers having reference count (semaphore) kbuild test robot
2018-04-04 8:31 ` [PATCH v2 7/9] trace_uprobe/sdt: Fix multiple update of same reference counter Ravi Bangoria
2018-04-04 13:18 ` kbuild test robot [this message]
2018-04-04 13:24 ` kbuild test robot
2018-04-09 13:17 ` Oleg Nesterov
2018-04-09 13:32 ` Ravi Bangoria
2018-04-09 13:41 ` Ravi Bangoria
2018-04-09 13:29 ` Oleg Nesterov
2018-04-10 8:19 ` Ravi Bangoria
2018-04-10 11:06 ` Oleg Nesterov
2018-04-11 4:28 ` Ravi Bangoria
2018-04-04 8:31 ` [PATCH v2 8/9] trace_uprobe/sdt: Document about " Ravi Bangoria
2018-04-04 8:31 ` [PATCH v2 9/9] perf probe: Support SDT markers having reference counter (semaphore) Ravi Bangoria
2018-04-09 7:28 ` Masami Hiramatsu
2018-04-09 8:29 ` Ravi Bangoria
2018-04-09 14:08 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201804042112.fiyMtCnW%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexis.berlemont@gmail.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=fengguang.wu@intel.com \
--cc=jglisse@redhat.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=kbuild-all@01.org \
--cc=kjlx@templeofstupid.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhiramat@kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=oleg@redhat.com \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).