From: Herbert Xu <herbert@gondor.apana.org.au>
To: Salvatore Mesoraca <s.mesoraca16@gmail.com>
Cc: linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Kees Cook <keescook@chromium.org>,
Eric Biggers <ebiggers3@gmail.com>,
Laura Abbott <labbott@redhat.com>
Subject: Re: [PATCH 3/6] crypto: api - avoid VLA use
Date: Sun, 8 Apr 2018 11:16:20 +0800 [thread overview]
Message-ID: <20180408031619.GB25197@gondor.apana.org.au> (raw)
In-Reply-To: <1523126303-23205-4-git-send-email-s.mesoraca16@gmail.com>
On Sat, Apr 07, 2018 at 08:38:20PM +0200, Salvatore Mesoraca wrote:
>
> int crypto_init_cipher_ops(struct crypto_tfm *tfm)
> {
> + const unsigned long alignmask = crypto_tfm_alg_alignmask(tfm);
> + const unsigned int size = crypto_tfm_alg_blocksize(tfm);
> struct cipher_tfm *ops = &tfm->crt_cipher;
> struct cipher_alg *cipher = &tfm->__crt_alg->cra_cipher;
>
> + if (size > MAX_BLOCKSIZE || alignmask > MAX_ALIGNMASK)
> + return -EINVAL;
> +
This check should be done when the algorithm is registered. Perhaps
crypto_check_alg.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-04-08 3:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 18:38 [PATCH 0/6] Remove several VLAs in the crypto subsystem Salvatore Mesoraca
2018-04-07 18:38 ` [PATCH 1/6] crypto: api - laying macros for statically allocated buffers Salvatore Mesoraca
2018-04-08 3:15 ` Herbert Xu
2018-04-08 8:56 ` Salvatore Mesoraca
2018-04-07 18:38 ` [PATCH 2/6] crypto: ctr - avoid VLA use Salvatore Mesoraca
2018-04-08 3:19 ` Herbert Xu
2018-04-08 8:58 ` Salvatore Mesoraca
2018-04-08 9:18 ` Herbert Xu
2018-04-07 18:38 ` [PATCH 3/6] crypto: api " Salvatore Mesoraca
2018-04-08 3:16 ` Herbert Xu [this message]
2018-04-08 9:07 ` Salvatore Mesoraca
2018-04-08 9:22 ` Herbert Xu
2018-04-09 13:27 ` Salvatore Mesoraca
2018-04-07 18:38 ` [PATCH 4/6] crypto: pcbc " Salvatore Mesoraca
2018-04-07 18:38 ` [PATCH 5/6] crypto: cts " Salvatore Mesoraca
2018-04-07 18:38 ` [PATCH 6/6] crypto: cfb " Salvatore Mesoraca
2018-04-07 19:56 ` [PATCH 0/6] Remove several VLAs in the crypto subsystem Kees Cook
2018-04-08 8:55 ` Salvatore Mesoraca
2018-04-09 13:53 Salvatore Mesoraca
2018-04-09 13:54 ` [PATCH 3/6] crypto: api - avoid VLA use Salvatore Mesoraca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180408031619.GB25197@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=ebiggers3@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.mesoraca16@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).