From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbeDHPme (ORCPT ); Sun, 8 Apr 2018 11:42:34 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58994 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752239AbeDHPmc (ORCPT ); Sun, 8 Apr 2018 11:42:32 -0400 Date: Sun, 8 Apr 2018 11:42:31 -0400 From: Joe Lawrence To: Josh Poimboeuf Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/livepatch: introduce tests Message-ID: <20180408154231.ihnglqyya5nric4q@redhat.com> References: <1522266588-11806-1-git-send-email-joe.lawrence@redhat.com> <1522266588-11806-2-git-send-email-joe.lawrence@redhat.com> <20180407023646.k3gjrgjwzhwgu6fq@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180407023646.k3gjrgjwzhwgu6fq@treble> User-Agent: Mutt/1.6.2-neo (2016-08-08) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 06, 2018 at 09:36:46PM -0500, Josh Poimboeuf wrote: > On Wed, Mar 28, 2018 at 03:49:48PM -0400, Joe Lawrence wrote: > > Add a few livepatch modules and simple target modules that the included > > regression suite can run tests against. > > > > Signed-off-by: Joe Lawrence > > --- > > lib/Kconfig.debug | 12 + > > lib/Makefile | 2 + > > lib/livepatch/Makefile | 18 + > > lib/livepatch/test_klp_atomic_replace.c | 69 +++ > > lib/livepatch/test_klp_callbacks_busy.c | 43 ++ > > lib/livepatch/test_klp_callbacks_demo.c | 132 ++++++ > > lib/livepatch/test_klp_callbacks_demo2.c | 104 ++++ > > lib/livepatch/test_klp_callbacks_mod.c | 24 + > > lib/livepatch/test_klp_livepatch.c | 62 +++ > > tools/testing/selftests/Makefile | 1 + > > tools/testing/selftests/livepatch/Makefile | 8 + > > tools/testing/selftests/livepatch/config | 1 + > > tools/testing/selftests/livepatch/functions.sh | 202 ++++++++ > > .../testing/selftests/livepatch/test-callbacks.sh | 526 +++++++++++++++++++++ > > .../testing/selftests/livepatch/test-livepatch.sh | 177 +++++++ > > .../selftests/livepatch/test-shadow-vars.sh | 13 + > > 16 files changed, 1394 insertions(+) > > create mode 100644 lib/livepatch/Makefile > > create mode 100644 lib/livepatch/test_klp_atomic_replace.c > > create mode 100644 lib/livepatch/test_klp_callbacks_busy.c > > create mode 100644 lib/livepatch/test_klp_callbacks_demo.c > > create mode 100644 lib/livepatch/test_klp_callbacks_demo2.c > > create mode 100644 lib/livepatch/test_klp_callbacks_mod.c > > create mode 100644 lib/livepatch/test_klp_livepatch.c > > create mode 100644 tools/testing/selftests/livepatch/Makefile > > create mode 100644 tools/testing/selftests/livepatch/config > > create mode 100644 tools/testing/selftests/livepatch/functions.sh > > create mode 100755 tools/testing/selftests/livepatch/test-callbacks.sh > > create mode 100755 tools/testing/selftests/livepatch/test-livepatch.sh > > create mode 100755 tools/testing/selftests/livepatch/test-shadow-vars.sh > > I love this. Nice work! > > As you and Petr discussed, it would be nice to get rid of some of the > delays, and also the callback tests will be very important. I've got v2 WIP that minimizes the delays, cleans up build flags, and adds a basic shadow variable test. Since these tests are based on top of Petr's current patchsets for atomic replace and shadow variables, it probably makes sense for those to merge first. I can post test results to his patchsets if that helps. These tests are basically a mash up of some of the tedious callback Documentation and shadow variable sample livepatches. Since there will be a lot of duplication, should we just remove redundant doc/samples in favor of these tests? -- Joe