From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [for-next][PATCH 4/4] init: Have initcall_debug still work without CONFIG_TRACEPOINTS
Date: Sun, 08 Apr 2018 16:10:04 -0400 [thread overview]
Message-ID: <20180408201204.319568252@goodmis.org> (raw)
In-Reply-To: 20180408201000.540816094@goodmis.org
[-- Attachment #1: 0004-init-Have-initcall_debug-still-work-without-CONFIG_T.patch --]
[-- Type: text/plain, Size: 2014 bytes --]
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Add macros around the initcall_debug tracepoint code to have the code to
default back to the old method if CONFIG_TRACEPOINTS is not enabled.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
init/main.c | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/init/main.c b/init/main.c
index 589d1226016e..6f6e6fc6f4b9 100644
--- a/init/main.c
+++ b/init/main.c
@@ -496,7 +496,14 @@ void __init __weak mem_encrypt_init(void) { }
bool initcall_debug;
core_param(initcall_debug, initcall_debug, bool, 0644);
+
+#ifdef TRACEPOINTS_ENABLED
static void __init initcall_debug_enable(void);
+#else
+static inline void initcall_debug_enable(void)
+{
+}
+#endif
/*
* Set up kernel memory allocators
@@ -832,6 +839,7 @@ trace_initcall_finish_cb(void *data, initcall_t fn, int ret)
static ktime_t initcall_calltime;
+#ifdef TRACEPOINTS_ENABLED
static void __init initcall_debug_enable(void)
{
int ret;
@@ -842,6 +850,22 @@ static void __init initcall_debug_enable(void)
&initcall_calltime);
WARN(ret, "Failed to register initcall tracepoints\n");
}
+# define do_trace_initcall_start trace_initcall_start
+# define do_trace_initcall_finish trace_initcall_finish
+#else
+static inline void do_trace_initcall_start(initcall_t fn)
+{
+ if (!initcall_debug)
+ return;
+ trace_initcall_start_cb(&initcall_calltime, fn);
+}
+static inline void do_trace_initcall_finish(initcall_t fn, int ret)
+{
+ if (!initcall_debug)
+ return;
+ trace_initcall_finish_cb(&initcall_calltime, fn, ret);
+}
+#endif /* !TRACEPOINTS_ENABLED */
int __init_or_module do_one_initcall(initcall_t fn)
{
@@ -852,9 +876,9 @@ int __init_or_module do_one_initcall(initcall_t fn)
if (initcall_blacklisted(fn))
return -EPERM;
- trace_initcall_start(fn);
+ do_trace_initcall_start(fn);
ret = fn();
- trace_initcall_finish(fn, ret);
+ do_trace_initcall_finish(fn, ret);
msgbuf[0] = 0;
--
2.16.3
prev parent reply other threads:[~2018-04-08 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 20:10 [for-next][PATCH 0/4] tracing: Addition of initcall tracing Steven Rostedt
2018-04-08 20:10 ` [for-next][PATCH 1/4] init, tracing: Add initcall trace events Steven Rostedt
2018-04-08 20:10 ` [for-next][PATCH 2/4] init, tracing: instrument security and console " Steven Rostedt
2018-04-08 20:10 ` [for-next][PATCH 3/4] init, tracing: Have printk come through the trace events for initcall_debug Steven Rostedt
2018-04-08 20:10 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180408201204.319568252@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).