From: David Miller <davem@davemloft.net>
To: Vadim.Lomovtsev@caviumnetworks.com
Cc: sgoutham@cavium.com, sunil.kovvuri@gmail.com, rric@kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dnelson@redhat.com,
robin.murphy@arm.com, hch@infradead.org, gustavo@embeddedor.com,
Vadim.Lomovtsev@cavium.com
Subject: Re: [PATCH v5] net: thunderx: rework mac addresses list to u64 array
Date: Mon, 09 Apr 2018 11:00:16 -0400 (EDT) [thread overview]
Message-ID: <20180409.110016.166919257730352493.davem@davemloft.net> (raw)
In-Reply-To: <20180409132448.22278-1-Vadim.Lomovtsev@caviumnetworks.com>
From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
Date: Mon, 9 Apr 2018 06:24:48 -0700
> From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
>
> It is too expensive to pass u64 values via linked list, instead
> allocate array for them by overall number of mac addresses from netdev.
>
> This eventually removes multiple kmalloc() calls, aviod memory
> fragmentation and allow to put single null check on kmalloc
> return value in order to prevent a potential null pointer dereference.
>
> Addresses-Coverity-ID: 1467429 ("Dereference null return value")
> Fixes: 37c3347eb247 ("net: thunderx: add ndo_set_rx_mode callback implementation for VF")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
Applied, thanks.
next prev parent reply other threads:[~2018-04-09 15:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 14:57 [PATCH] net: thunderx: rework mac addresses list to u64 array Vadim Lomovtsev
2018-04-05 15:00 ` Vadim Lomovtsev
2018-04-05 15:07 ` Christoph Hellwig
2018-04-05 16:07 ` Vadim Lomovtsev
2018-04-05 16:15 ` Christoph Hellwig
2018-04-06 11:14 ` [PATCH v2] " Vadim Lomovtsev
2018-04-06 11:36 ` Gustavo A. R. Silva
2018-04-06 11:43 ` Vadim Lomovtsev
2018-04-06 11:47 ` Gustavo A. R. Silva
2018-04-06 11:53 ` Vadim Lomovtsev
2018-04-06 11:48 ` Robin Murphy
2018-04-06 12:07 ` Vadim Lomovtsev
2018-04-06 14:04 ` [PATCH v3] " Vadim Lomovtsev
2018-04-06 15:16 ` Vadim Lomovtsev
2018-04-06 19:53 ` [PATCH v4] " Vadim Lomovtsev
2018-04-08 16:42 ` David Miller
2018-04-09 9:42 ` Vadim Lomovtsev
2018-04-09 13:24 ` [PATCH v5] " Vadim Lomovtsev
2018-04-09 15:00 ` David Miller [this message]
2018-04-06 15:06 ` [PATCH v2] " David Miller
2018-04-06 15:14 ` Vadim Lomovtsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409.110016.166919257730352493.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Vadim.Lomovtsev@cavium.com \
--cc=Vadim.Lomovtsev@caviumnetworks.com \
--cc=dnelson@redhat.com \
--cc=gustavo@embeddedor.com \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
--cc=sunil.kovvuri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).