From: Tiwei Bie <tiwei.bie@intel.com>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, wexu@redhat.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jfreimann@redhat.com
Subject: Re: [RFC v2] virtio: support packed ring
Date: Tue, 10 Apr 2018 11:21:34 +0800 [thread overview]
Message-ID: <20180410032134.qco4ut2s3lo2zgsc@debian> (raw)
In-Reply-To: <5cf4d5d6-c416-28af-0568-750e9f654710@redhat.com>
On Tue, Apr 10, 2018 at 10:55:25AM +0800, Jason Wang wrote:
> On 2018年04月01日 22:12, Tiwei Bie wrote:
> > Hello everyone,
> >
> > This RFC implements packed ring support for virtio driver.
> >
> > The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented
> > by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html
> > Minor changes are needed for the vhost code, e.g. to kick the guest.
> >
> > TODO:
> > - Refinements and bug fixes;
> > - Split into small patches;
> > - Test indirect descriptor support;
> > - Test/fix event suppression support;
> > - Test devices other than net;
> >
> > RFC v1 -> RFC v2:
> > - Add indirect descriptor support - compile test only;
> > - Add event suppression supprt - compile test only;
> > - Move vring_packed_init() out of uapi (Jason, MST);
> > - Merge two loops into one in virtqueue_add_packed() (Jason);
> > - Split vring_unmap_one() for packed ring and split ring (Jason);
> > - Avoid using '%' operator (Jason);
> > - Rename free_head -> next_avail_idx (Jason);
> > - Add comments for virtio_wmb() in virtqueue_add_packed() (Jason);
> > - Some other refinements and bug fixes;
> >
> > Thanks!
>
> Will try to review this later.
>
> But it would be better if you can split it (more than 1000 lines is too big
> to be reviewed easily). E.g you can at least split it into three patches,
> new structures, datapath, and event suppression.
>
No problem! It's on my TODO list. I'll get it done in the next version.
Thanks!
next prev parent reply other threads:[~2018-04-10 3:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 14:12 [RFC v2] virtio: support packed ring Tiwei Bie
2018-04-10 2:55 ` Jason Wang
2018-04-10 3:21 ` Tiwei Bie [this message]
2018-04-13 4:30 ` Jason Wang
2018-04-13 7:15 ` Tiwei Bie
2018-04-17 2:11 ` Jason Wang
2018-04-17 2:17 ` Michael S. Tsirkin
2018-04-17 2:24 ` Jason Wang
2018-04-17 2:37 ` Michael S. Tsirkin
2018-04-17 2:51 ` Tiwei Bie
2018-04-17 12:17 ` Michael S. Tsirkin
2018-04-17 12:47 ` Tiwei Bie
2018-04-17 14:04 ` Michael S. Tsirkin
2018-04-17 14:56 ` Tiwei Bie
2018-04-17 15:54 ` Michael S. Tsirkin
2018-04-18 1:17 ` Tiwei Bie
2018-04-13 15:22 ` Michael S. Tsirkin
2018-04-14 11:22 ` Tiwei Bie
2018-04-23 5:42 ` Jason Wang
2018-04-23 9:29 ` Tiwei Bie
2018-04-24 0:54 ` Jason Wang
2018-04-24 1:05 ` Michael S. Tsirkin
2018-04-24 1:14 ` Jason Wang
2018-04-24 1:16 ` Tiwei Bie
2018-04-24 1:29 ` Michael S. Tsirkin
2018-04-24 1:37 ` Tiwei Bie
2018-04-24 1:43 ` Michael S. Tsirkin
2018-04-24 1:49 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410032134.qco4ut2s3lo2zgsc@debian \
--to=tiwei.bie@intel.com \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).