From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4+9DbIdpr6hxaPTI9Hikjf2fFK2cMAzM0tT9hldEAzpfVxMQgpG4J2GbKCLZYWECJklCL5z ARC-Seal: i=1; a=rsa-sha256; t=1523399355; cv=none; d=google.com; s=arc-20160816; b=lx9nT3pzll/DUH3NrDK2eEPDCsCsx51MMZ6HZp4UQQaYHDpcKBZ5d/RAYO4FkaUieD hQqKKoxk1347UH5cQqd2Df/holA3EWdq9AAkvKTUZrCHWi6ETvjzlRawFnGDTsPJENlu cD0dkrPpvQGDwQomTRSkaeivwKcN/0kurkUyMUsl5YlbFjO5WzcrSpq71KB5grliWrCI RzOFzgS4iWH0/qKV6M2lZir/I5ySyJ1lSe8wXjeUH/D413w8YZfEMlhth5jHsM1QmTzq bgtUj9UnY01AhVoCVXtBTj+jJJgi98lSbJNW29wb/WNWjoy/jvAr/eNyFEb9hJ4GNCfl LyWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=0bdZ2W7o21NOUT65l7Ul++mGqi2sRI7VbdXuzcI9qsY=; b=nEBHgrMiOJsoLeSPK7gz8bC1OSh33sy2BP4IMoAitufIxjbZjA7op8Tlpwj45o4Xa9 2Tt+8lgJM2fFIQPi+pmh7jkBBnjWD1R6iMax/8sUoyUmPIVbou2hnC39SlTPXrzSZKLN LTL0ZnOMUNCl3chGwS+iAdqsXBKwCB702RHS4++Kop0oRkc2nbbKZLk2A+bY5bIC6+Rj 3UdV63a+Gapq7llrccJ3woy0+b+9PvQ2XeImI2hJWmhNjXJScBhXTtkvOza9kN0gcDHr szPyOQco3nwGnUZclaQlwwKAenQdbmyogfdD4i4ctSJB7hqRrM/jbHWh2WVz/h5PnIjT lRFg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, James Smart , Christoph Hellwig , Sasha Levin Subject: [PATCH 4.15 059/168] nvme_fcloop: fix abort race condition Date: Wed, 11 Apr 2018 00:23:21 +0200 Message-Id: <20180410212802.716886067@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180410212800.144079021@linuxfoundation.org> References: <20180410212800.144079021@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1597400002066547044?= X-GMAIL-MSGID: =?utf-8?q?1597400002066547044?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: James Smart [ Upstream commit 278e096063f1914fccfc77a617be9fc8dbb31b0e ] A test case revealed a race condition of an i/o completing on a thread parallel to the delete_association generating the aborts for the outstanding ios on the controller. The i/o completion was freeing the target fcloop context, thus the abort task referenced the just-freed memory. Correct by clearing the target/initiator cross pointers in the io completion and abort tasks before calling the callbacks. On aborts that detect already finished io's, ensure the complete context is called. Signed-off-by: James Smart Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/target/fcloop.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) --- a/drivers/nvme/target/fcloop.c +++ b/drivers/nvme/target/fcloop.c @@ -374,6 +374,7 @@ fcloop_tgt_fcprqst_done_work(struct work spin_lock(&tfcp_req->reqlock); fcpreq = tfcp_req->fcpreq; + tfcp_req->fcpreq = NULL; spin_unlock(&tfcp_req->reqlock); if (tport->remoteport && fcpreq) { @@ -615,11 +616,7 @@ fcloop_fcp_abort(struct nvme_fc_local_po if (!tfcp_req) /* abort has already been called */ - return; - - if (rport->targetport) - nvmet_fc_rcv_fcp_abort(rport->targetport, - &tfcp_req->tgt_fcp_req); + goto finish; /* break initiator/target relationship for io */ spin_lock(&tfcp_req->reqlock); @@ -627,6 +624,11 @@ fcloop_fcp_abort(struct nvme_fc_local_po tfcp_req->fcpreq = NULL; spin_unlock(&tfcp_req->reqlock); + if (rport->targetport) + nvmet_fc_rcv_fcp_abort(rport->targetport, + &tfcp_req->tgt_fcp_req); + +finish: /* post the aborted io completion */ fcpreq->status = -ECANCELED; schedule_work(&inireq->iniwork);