From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Paul Kocialkowski <contact@paulk.fr>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH 1/3] drm/panel: Add RGB666 variant of Innolux AT070TN92
Date: Wed, 11 Apr 2018 08:28:35 +0200 [thread overview]
Message-ID: <20180411062835.oqzd34e2szrnv34b@flea> (raw)
In-Reply-To: <20180410213129.24049-1-contact@paulk.fr>
[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]
On Tue, Apr 10, 2018 at 11:31:27PM +0200, Paul Kocialkowski wrote:
> This adds timings for the RGB666 variant of the Innolux AT070TN92 panel,
> as found on the Ainol AW1 tablet.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 5591984a392b..efeb2f2162bc 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1063,6 +1063,29 @@ static const struct panel_desc innolux_at070tn92 = {
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> };
>
> +static const struct drm_display_mode innolux_at070tn92_rgb666_mode = {
> + .clock = 40000,
> + .hdisplay = 800,
> + .hsync_start = 800 + 112,
> + .hsync_end = 800 + 112 + 1,
> + .htotal = 800 + 112 + 1 + 87,
> + .vdisplay = 480,
> + .vsync_start = 480 + 141,
> + .vsync_end = 480 + 141 + 1,
> + .vtotal = 480 + 141 + 1 + 38,
> + .vrefresh = 60,
> +};
I'm not sure why you'd need different timings if the only difference
is the bus width.
> +static const struct panel_desc innolux_at070tn92_rgb666 = {
> + .modes = &innolux_at070tn92_rgb666_mode,
> + .num_modes = 1,
> + .size = {
> + .width = 154,
> + .height = 86,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +};
> +
> static const struct display_timing innolux_g101ice_l01_timing = {
> .pixelclock = { 60400000, 71100000, 74700000 },
> .hactive = { 1280, 1280, 1280 },
> @@ -2105,6 +2128,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "innolux,at070tn92",
> .data = &innolux_at070tn92,
> + }, {
> + .compatible = "innolux,at070tn92-rgb666",
> + .data = &innolux_at070tn92_rgb666,
And this isn't a different device, it's just the integration in the
board that is different, so you shouldn't have a different compatible
here, but rather something like the bus-width property documented in
the Documentation/devicetree/bindings/media/video-interfaces.txt file.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-04-11 6:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 21:31 [PATCH 1/3] drm/panel: Add RGB666 variant of Innolux AT070TN92 Paul Kocialkowski
2018-04-10 21:31 ` [PATCH 2/3] ARM: dts: sun7i: Add RGB666 pins definition Paul Kocialkowski
2018-04-11 22:22 ` Giulio Benetti
2018-04-11 23:09 ` [linux-sunxi] " Paul Kocialkowski
2018-04-11 23:19 ` Giulio Benetti
2018-04-10 21:31 ` [PATCH 3/3] ARM: dts: sun7i: Add support for the Ainol AW1 tablet Paul Kocialkowski
2018-04-10 21:35 ` Paul Kocialkowski
2018-04-11 6:09 ` [linux-sunxi] " Paul Kocialkowski
2018-04-11 7:06 ` Maxime Ripard
2018-04-11 23:08 ` Paul Kocialkowski
2018-04-12 14:51 ` Maxime Ripard
2018-04-11 6:28 ` Maxime Ripard [this message]
2018-04-11 23:12 ` [PATCH 1/3] drm/panel: Add RGB666 variant of Innolux AT070TN92 Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411062835.oqzd34e2szrnv34b@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=contact@paulk.fr \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).