From: Vinod Koul <vinod.koul@intel.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: dan.j.williams@intel.com, eric.long@spreadtrum.com,
broonie@kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type
Date: Wed, 11 Apr 2018 14:54:03 +0530 [thread overview]
Message-ID: <20180411092402.GB6014@localhost> (raw)
In-Reply-To: <abdda9da96185f764d58bbf61db9010d0f72d1b3.1523346135.git.baolin.wang@linaro.org>
On Tue, Apr 10, 2018 at 03:46:03PM +0800, Baolin Wang wrote:
> From: Eric Long <eric.long@spreadtrum.com>
>
> Define the DMA transfer step type to make code more readable.
>
> Signed-off-by: Eric Long <eric.long@spreadtrum.com>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> drivers/dma/sprd-dma.c | 28 ++++++++++++++++++++++------
> 1 file changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index b106e8a..af9c156 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -169,6 +169,22 @@ enum sprd_dma_int_type {
> SPRD_DMA_CFGERR_INT,
> };
>
> +/*
> + * enum sprd_dma_step: define the DMA transfer step type
> + * @SPRD_DMA_NONE_STEP: transfer do not need step
> + * @SPRD_DMA_BYTE_STEP: transfer step is one byte
> + * @SPRD_DMA_SHORT_STEP: transfer step is two bytes
> + * @SPRD_DMA_WORD_STEP: transfer step is one word
> + * @SPRD_DMA_DWORD_STEP: transfer step is double word
> + */
> +enum sprd_dma_step {
looking at bit defines, does it need to be enum? a #define would just be fine.
> + SPRD_DMA_NONE_STEP,
> + SPRD_DMA_BYTE_STEP = BIT(0),
> + SPRD_DMA_SHORT_STEP = BIT(1),
> + SPRD_DMA_WORD_STEP = BIT(2),
> + SPRD_DMA_DWORD_STEP = BIT(3),
> +};
> +
> /* dma channel hardware configuration */
> struct sprd_dma_chn_hw {
> u32 pause;
> @@ -598,16 +614,16 @@ static int sprd_dma_config(struct dma_chan *chan, struct sprd_dma_desc *sdesc,
>
> if (IS_ALIGNED(len, 4)) {
> datawidth = 2;
> - src_step = 4;
> - des_step = 4;
> + src_step = SPRD_DMA_WORD_STEP;
> + des_step = SPRD_DMA_WORD_STEP;
> } else if (IS_ALIGNED(len, 2)) {
> datawidth = 1;
> - src_step = 2;
> - des_step = 2;
> + src_step = SPRD_DMA_SHORT_STEP;
> + des_step = SPRD_DMA_SHORT_STEP;
> } else {
> datawidth = 0;
> - src_step = 1;
> - des_step = 1;
> + src_step = SPRD_DMA_BYTE_STEP;
> + des_step = SPRD_DMA_BYTE_STEP;
> }
>
> fragment_len = SPRD_DMA_MEMCPY_MIN_SIZE;
> --
> 1.7.9.5
>
--
~Vinod
next prev parent reply other threads:[~2018-04-11 9:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 7:46 [PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang
2018-04-10 7:46 ` [PATCH 2/5] dmaengine: sprd: Define the DMA data width type Baolin Wang
2018-04-10 7:46 ` [PATCH 3/5] dmaengine: sprd: Move DMA request mode and interrupt type into head file Baolin Wang
2018-04-10 7:46 ` [PATCH 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang
2018-04-11 9:36 ` Vinod Koul
2018-04-11 12:13 ` Baolin Wang
2018-04-12 9:37 ` Vinod Koul
2018-04-12 11:30 ` Baolin Wang
2018-04-12 11:36 ` Baolin Wang
2018-04-13 3:43 ` Vinod Koul
2018-04-13 6:17 ` Baolin Wang
2018-04-13 6:36 ` Vinod Koul
2018-04-13 6:41 ` Baolin Wang
2018-04-13 10:11 ` Vinod Koul
2018-04-13 10:48 ` Baolin Wang
2018-04-16 3:58 ` Vinod Koul
2018-04-16 6:32 ` Baolin Wang
2018-04-16 15:35 ` Vinod Koul
2018-04-17 6:06 ` Baolin Wang
2018-04-13 3:39 ` Vinod Koul
2018-04-13 5:44 ` Baolin Wang
2018-04-10 7:46 ` [PATCH 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang
2018-04-11 9:40 ` Vinod Koul
2018-04-11 10:51 ` Baolin Wang
2018-04-17 10:45 ` Lars-Peter Clausen
2018-04-18 5:40 ` Baolin Wang
2018-04-11 9:24 ` Vinod Koul [this message]
2018-04-11 10:49 ` [PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411092402.GB6014@localhost \
--to=vinod.koul@intel.com \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.long@spreadtrum.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).