From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Joey Pabalinas <joeypabalinas@gmail.com>
Cc: linux-sparse@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Martin Uecker <Martin.Uecker@med.uni-goettingen.de>,
Al Viro <viro@ZenIV.linux.org.uk>,
Christopher Li <sparse@chrisli.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] sparse: add -Wpointer-arith flag to toggle sizeof(void) warnings
Date: Wed, 11 Apr 2018 12:20:08 +0200 [thread overview]
Message-ID: <20180411102007.i6nkdh6pff5ycmu6@ltop.local> (raw)
In-Reply-To: <20180410224624.psyo7vsy4qjplh3j@gmail.com>
On Tue, Apr 10, 2018 at 12:46:24PM -1000, Joey Pabalinas wrote:
> Recent changes to the min()/max() macros in include/linux/kernel.h
> have added a lot of noise when compiling the kernel with Sparse checking
> enabled. This mostly is due to the *huge* increase in the number of
> sizeof(void) warnings, a larger number of which can safely be ignored.
>
> Add the -Wpointer-arith flag to enable/disable these warnings (along
> with the warning when applying sizeof to function types as well as
> warning about pointer arithmetic on these types exactly like the
> GCC -Wpointer-arith flag) on demand; the warning itself has been disabled
> by default to reduce the large influx of noise which was inadvertently
> added by commit 3c8ba0d61d04ced9f8 (kernel.h: Retain constant expression
> output for max()/min()).
>
> Update the manpage to document the new flag and add a validation case
> for sizeof(void).
>
> CC: Kees Cook <keescook@chromium.org>
> CC: Linus Torvalds <torvalds@linux-foundation.org>
> CC: Martin Uecker <Martin.Uecker@med.uni-goettingen.de>
> CC: Al Viro <viro@ZenIV.linux.org.uk>
> CC: Christopher Li <sparse@chrisli.org>
> CC: Joey Pabalinas <joeypabalinas@gmail.com>
> CC: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Thanks,
Acked-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
prev parent reply other threads:[~2018-04-11 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 22:46 [PATCH v4] sparse: add -Wpointer-arith flag to toggle sizeof(void) warnings Joey Pabalinas
2018-04-11 10:20 ` Luc Van Oostenryck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411102007.i6nkdh6pff5ycmu6@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=Martin.Uecker@med.uni-goettingen.de \
--cc=joeypabalinas@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).