From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3339499-1523479701-2-15454253906693167882 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523479701; b=lWIy261uSdoQQ5qVllB0INgmfDpOoq+OWc4N1SVAXbyGazNunf 9HnerF/u24B1zqziels9F6aQIAg3If3bhcW58Yf3VmWkQsheUr7gHg10Qlqxq/yf C3fTNNLciTX1GffjRviQGFh/QXyNBIgn3CVU3foOBfDOjgkgArpnWcCuvmXuIhsF MiA7whbFyq5MVXyEqCYQYAnTDwkOLgBLJZsBTqH/iRDFtpDVNIS90WrVduPruGfr jjyUy52lLLJa9Oy19UJsTuBFdoPOcVvLbBMsZK44NKKpew2Je1yVRQSMqWwJLunv Wd+zN2eBJ/Pa2HjchByTlY6BD83+nWo0hPPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=fm2; t=1523479701; bh=oboxtM847a/kcVrcsJP0Fc/iGE4/Mr 5+8tKgeNbUOsM=; b=nLHUFtrdGHZh/bwXIvAEGsPYlIaWeSDHO+dwu8JFqVhW1g RXIJRiRtFtwo0vR/P4pX6BvrXi7dKB5IE3NxpWLTPD93vPaI0jCHMvud7sNf1Hrl sIjTiI7suCCY3xaYPs601otdgE8IO9AvPsAmKKYJ2c/FDoJrPyuPI14Zq/dmsidT V2hjFv+mDSHksUw8K+loT3dG42OAOm741sDvYB4hqwPLX/D1/W6rPhzvi9578BT/ knQfdSH/Loc0bqAY6XnnzEZUvDPQOX9qVKR6iXYIUinnzNvLpidOSqNOHQGa24u+ +1xhZePHsrAEJQe49nuFdBnaVncu7OEN+lqBEbsQ== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfAoFw+8fmWAO2vVs8n3lYTQHelFf1SfRnrGlCXm1guBDrSr+t0tb/VOrlgraOkRlhzypBrycWjd1dXCNCW5S4++7RiXjSizxiLp7z3sazMp+7iKBaPQv TnOmzSIf+DFCUU9hZLo2fkNOhDXU5eNR2iGfc7XViZhOSYV73TcubbY21WEQA+E8K7qEtVGcOxqLgQJz8fugocfiloY+v5fiHdf+52jzmDP3gWdRznN80gFW X-CM-Analysis: v=2.3 cv=NPP7BXyg c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=yPCof4ZbAAAA:8 a=QyXUC8HyAAAA:8 a=yMhMjlubAAAA:8 a=ag1SF4gXAAAA:8 a=e4JcQNwn_gKbhmeX78YA:9 a=QEXdDO2ut3YA:10 a=Yupwre4RP9_Eg_Bd0iYG:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754294AbeDKSqT (ORCPT ); Wed, 11 Apr 2018 14:46:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58874 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754987AbeDKSqR (ORCPT ); Wed, 11 Apr 2018 14:46:17 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Srinivas Pandruvada , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 4.4 031/190] PowerCap: Fix an error code in powercap_register_zone() Date: Wed, 11 Apr 2018 20:34:37 +0200 Message-Id: <20180411183552.017034295@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183550.114495991@linuxfoundation.org> References: <20180411183550.114495991@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 216c4e9db4c9d1d2a382b42880442dc632cd47d9 ] In the current code we accidentally return the successful result from idr_alloc() instead of a negative error pointer. The caller is looking for an error pointer and so it treats the returned value as a valid pointer. This one might be a bit serious because if it lets people get around the kernel's protection for remapping NULL. I'm not sure. Fixes: 75d2364ea0ca (PowerCap: Add class driver) Signed-off-by: Dan Carpenter Reviewed-by: Srinivas Pandruvada Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/powercap/powercap_sys.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/powercap/powercap_sys.c +++ b/drivers/powercap/powercap_sys.c @@ -538,6 +538,7 @@ struct powercap_zone *powercap_register_ power_zone->id = result; idr_init(&power_zone->idr); + result = -ENOMEM; power_zone->name = kstrdup(name, GFP_KERNEL); if (!power_zone->name) goto err_name_alloc;