From: kbuild test robot <lkp@intel.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: kbuild-all@01.org, peterz@infradead.org, tglx@linutronix.de,
mingo@kernel.org, longman@redhat.com, dave@stgolabs.net,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbues@suse.de>
Subject: Re: [PATCH 2/2] rtmutex: Reduce top-waiter blocking on a lock
Date: Wed, 11 Apr 2018 20:51:29 +0800 [thread overview]
Message-ID: <201804112023.tAv7vUah%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180410162750.8290-2-dave@stgolabs.net>
Hi Davidlohr,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.16 next-20180411]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Davidlohr-Bueso/locking-rtmutex-Delete-save_state-member-of-struct-rt_mutex/20180411-155733
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> kernel/locking/rtmutex_common.h:62:9: sparse: context imbalance in '__rt_mutex_slowlock' - unexpected unlock
vim +/__rt_mutex_slowlock +62 kernel/locking/rtmutex_common.h
23f78d4a0 kernel/rtmutex_common.h Ingo Molnar 2006-06-27 51
23f78d4a0 kernel/rtmutex_common.h Ingo Molnar 2006-06-27 52 static inline struct rt_mutex_waiter *
23f78d4a0 kernel/rtmutex_common.h Ingo Molnar 2006-06-27 53 rt_mutex_top_waiter(struct rt_mutex *lock)
23f78d4a0 kernel/rtmutex_common.h Ingo Molnar 2006-06-27 54 {
c28d62cf5 kernel/locking/rtmutex_common.h Peter Zijlstra 2018-03-27 55 struct rb_node *leftmost = rb_first_cached(&lock->waiters);
c28d62cf5 kernel/locking/rtmutex_common.h Peter Zijlstra 2018-03-27 56 struct rt_mutex_waiter *w = NULL;
23f78d4a0 kernel/rtmutex_common.h Ingo Molnar 2006-06-27 57
c28d62cf5 kernel/locking/rtmutex_common.h Peter Zijlstra 2018-03-27 58 if (leftmost) {
c28d62cf5 kernel/locking/rtmutex_common.h Peter Zijlstra 2018-03-27 59 w = rb_entry(leftmost, struct rt_mutex_waiter, tree_entry);
23f78d4a0 kernel/rtmutex_common.h Ingo Molnar 2006-06-27 60 BUG_ON(w->lock != lock);
c28d62cf5 kernel/locking/rtmutex_common.h Peter Zijlstra 2018-03-27 61 }
23f78d4a0 kernel/rtmutex_common.h Ingo Molnar 2006-06-27 @62 return w;
23f78d4a0 kernel/rtmutex_common.h Ingo Molnar 2006-06-27 63 }
23f78d4a0 kernel/rtmutex_common.h Ingo Molnar 2006-06-27 64
:::::: The code at line 62 was first introduced by commit
:::::: 23f78d4a03c53cbd75d87a795378ea540aa08c86 [PATCH] pi-futex: rt mutex core
:::::: TO: Ingo Molnar <mingo@elte.hu>
:::::: CC: Linus Torvalds <torvalds@g5.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-04-11 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 16:27 [PATCH 1/2] locking/rtmutex: Delete save_state member of struct rt_mutex Davidlohr Bueso
2018-04-10 16:27 ` [PATCH 2/2] rtmutex: Reduce top-waiter blocking on a lock Davidlohr Bueso
2018-04-11 12:51 ` kbuild test robot [this message]
2018-04-17 16:52 ` Davidlohr Bueso
2018-04-20 15:50 ` Peter Zijlstra
2018-04-20 16:48 ` Mike Galbraith
2018-04-22 2:39 ` Davidlohr Bueso
2018-06-17 17:26 ` Davidlohr Bueso
2018-04-20 15:25 ` [PATCH 3/2] rtmutex: Use waiter debug init,free magic numbers Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201804112023.tAv7vUah%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=dave@stgolabs.net \
--cc=dbues@suse.de \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).