From: Sandipan Das <sandipan@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@redhat.com
Cc: linux-kernel@vger.kernel.org, naveen.n.rao@linux.vnet.ibm.com,
ravi.bangoria@linux.vnet.ibm.com
Subject: [PATCH 2/2] perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64
Date: Thu, 12 Apr 2018 22:41:29 +0530 [thread overview]
Message-ID: <20180412171129.4422-3-sandipan@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180412171129.4422-1-sandipan@linux.vnet.ibm.com>
For powerpc64, this test currently fails due to a mismatch in
the expected output.
Before applying patch:
62: probe libc's inet_pton & backtrace it with ping :
--- start ---
test child forked, pid 27723
ping 27740 [012] 607801.690493: probe_libc:inet_pton: (7fff936caf28)
15af28 __GI___inet_pton (/usr/lib64/libc-2.26.so)
10fa54 gaih_inet.constprop.7 (/usr/lib64/libc-2.26.so)
FAIL: expected backtrace entry 2 "getaddrinfo[[:space:]]\(/usr/lib64/libc-2.26.so\)$" got "10fa54 gaih_inet.constprop.7 (/usr/lib64/libc-2.26.so)"
test child finished with -1
---- end ----
probe libc's inet_pton & backtrace it with ping: FAILED!
After applying patch:
62: probe libc's inet_pton & backtrace it with ping :
--- start ---
test child forked, pid 28782
ping 28799 [017] 608933.853323: probe_libc:inet_pton: (7fff891baf28)
15af28 __GI___inet_pton (/usr/lib64/libc-2.26.so)
10fa54 gaih_inet.constprop.7 (/usr/lib64/libc-2.26.so)
1105b4 getaddrinfo (/usr/lib64/libc-2.26.so)
2d70 _init (/usr/bin/ping)
test child finished with 0
---- end ----
probe libc's inet_pton & backtrace it with ping: Ok
Fixes: e07d585e2454 ("perf tests: Switch trace+probe_libc_inet_pton to use record")
Signed-off-by: Sandipan Das <sandipan@linux.vnet.ibm.com>
---
tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
index 1ecc1f0ff84a..b45afc59edc6 100755
--- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
+++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
@@ -26,6 +26,14 @@ trace_libc_inet_pton_backtrace() {
expected[5]="__libc_start_main[[:space:]]\($libc\)$"
expected[6]="_start[[:space:]]\(.*/bin/ping.*\)$"
;;
+ ppc64)
+ ;&
+ ppc64le)
+ eventattr='max-stack=4'
+ expected[2]="gaih_inet.*[[:space:]]\($libc\)$"
+ expected[3]="getaddrinfo[[:space:]]\($libc\)$"
+ expected[4]=".*\(.*/bin/ping.*\)$"
+ ;;
*)
eventattr='max-stack=3'
expected[2]="getaddrinfo[[:space:]]\($libc\)$"
--
2.14.3
prev parent reply other threads:[~2018-04-12 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 17:11 [PATCH 0/2] perf: Fixes for callchain ip handling on powerpc Sandipan Das
2018-04-12 17:11 ` [PATCH 1/2] perf tools powerpc: Fix callchain ip filtering Sandipan Das
2018-04-12 18:43 ` Arnaldo Carvalho de Melo
2018-04-12 19:55 ` Sandipan Das
2018-04-17 6:59 ` Ravi Bangoria
2018-04-17 15:00 ` Sandipan Das
2018-04-12 17:11 ` Sandipan Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412171129.4422-3-sandipan@linux.vnet.ibm.com \
--to=sandipan@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).