From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Oleksandr Andrushchenko <andr2000@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, jgross@suse.com,
iurii.konovalenko@globallogic.com, tiwai@suse.de,
Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Subject: Re: [PATCH RESEND] xen/sndif: Sync up with the canonical definition in Xen
Date: Thu, 12 Apr 2018 14:30:52 -0400 [thread overview]
Message-ID: <20180412183052.GS350@char.us.oracle.com> (raw)
In-Reply-To: <f3135104-f480-e1e8-0628-136bf265c2f6@oracle.com>
On Thu, Apr 12, 2018 at 01:46:33PM -0400, Boris Ostrovsky wrote:
> On 04/12/2018 01:26 PM, Oleksandr Andrushchenko wrote:
> > This is the sync up with the canonical definition of the sound
> > protocol in Xen:
> >
> > 1. Protocol version was referenced in the protocol description,
> > but missed its definition. Fixed by adding a constant
> > for current protocol version.
> >
> > 2. Some of the request descriptions have "reserved" fields
> > missed: fixed by adding corresponding entries.
> >
> > 3. Extend the size of the requests and responses to 64 octets.
> > Bump protocol version to 2.
> >
> > 4. Add explicit back and front synchronization
> > In order to provide explicit synchronization between backend and
> > frontend the following changes are introduced in the protocol:
> > - add new ring buffer for sending asynchronous events from
> > backend to frontend to report number of bytes played by the
> > frontend (XENSND_EVT_CUR_POS)
> > - introduce trigger events for playback control: start/stop/pause/resume
> > - add "req-" prefix to event-channel and ring-ref to unify naming
> > of the Xen event channels for requests and events
> >
> > 5. Add explicit back and front parameter negotiation
> > In order to provide explicit stream parameter negotiation between
> > backend and frontend the following changes are introduced in the protocol:
> > add XENSND_OP_HW_PARAM_QUERY request to read/update
> > configuration space for the parameters given: request passes
> > desired parameter's intervals/masks and the response to this request
> > returns allowed min/max intervals/masks to be used.
> >
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > ---
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thank you!
next prev parent reply other threads:[~2018-04-12 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 17:26 [PATCH RESEND] xen/sndif: Sync up with the canonical definition in Xen Oleksandr Andrushchenko
2018-04-12 17:46 ` Boris Ostrovsky
2018-04-12 18:30 ` Konrad Rzeszutek Wilk [this message]
2018-04-17 15:10 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412183052.GS350@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=andr2000@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=iurii.konovalenko@globallogic.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_grytsov@epam.com \
--cc=tiwai@suse.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).