linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Renato Soma <renatoys08@gmail.com>
Cc: devel@driverdev.osuosl.org, lkcamp@lists.libreplanetbr.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging fbtft: Fixed lines exceeding columns limit
Date: Fri, 13 Apr 2018 15:57:47 +0300	[thread overview]
Message-ID: <20180413125747.ccynu6twioa22fee@mwanda> (raw)
In-Reply-To: <20180413001602.GA18920@rys-Inspiron-5420>

>  	if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) {                    \
>  		va_start(args, len);                                          \
>  		for (i = 0; i < len; i++) {                                   \
> -			buf[i] = modifier((data_type)va_arg(args, unsigned int)); \
> +			buf[i] = modifier((data_type)va_arg(args,             \
> +						unsigned int));               \


Normally we'd align the parameters like so:

			buf[i] = modifier((data_type)va_arg(args,		\
							    unsigned int));	\



>  		}                                                             \
>  		va_end(args);                                                 \
> -		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, buffer_type, buf, len, "%s: ", __func__); \
> +		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,                  \
> +				par->info->device, buffer_type,               \
> +				buf, len, "%s: ", __func__);                  \
>  	}                                                                     \

Not properly aligned.


>  									      \
>  	va_start(args, len);                                                  \
> @@ -37,7 +40,8 @@ void func(struct fbtft_par *par, int len, ...)                                \
>  	}                                                                     \
>  									      \
>  	*buf = modifier((data_type)va_arg(args, unsigned int));               \
> -	ret = fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset, 0); \

I feel like the original is basically OK but if we're going to change it
then align it like this:

	ret = fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset,	\
				 0);						\


Etc.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-04-13 12:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13  0:16 [PATCH] staging fbtft: Fixed lines exceeding columns limit Renato Soma
2018-04-13 12:57 ` Dan Carpenter [this message]
2018-04-14  3:25   ` Renato Soma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180413125747.ccynu6twioa22fee@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=renatoys08@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).