linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: kbuild-all@01.org, jlbec@evilplan.org, drosen@google.com,
	linux-kernel@vger.kernel.org, jorgelo@chromium.org
Subject: Re: [PATCH] configfs: inherit file and directory owners
Date: Sat, 14 Apr 2018 06:35:56 +0800	[thread overview]
Message-ID: <201804140544.s6smIrG9%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180413105135.216944-1-gwendal@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 1986 bytes --]

Hi Gwendal,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.16 next-20180413]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Gwendal-Grignou/configfs-inherit-file-and-directory-owners/20180414-041333
config: x86_64-randconfig-x013-201814 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   fs/configfs/inode.c: In function 'alloc_iattr':
>> fs/configfs/inode.c:75:25: error: 'CURRENT_TIME' undeclared (first use in this function); did you mean 'CURRENT_MASK'?
       sd_iattr->ia_ctime = CURRENT_TIME;
                            ^~~~~~~~~~~~
                            CURRENT_MASK
   fs/configfs/inode.c:75:25: note: each undeclared identifier is reported only once for each function it appears in

vim +75 fs/configfs/inode.c

    56	
    57	static struct iattr *alloc_iattr(struct configfs_dirent *sd_parent,
    58							struct configfs_dirent *sd)
    59	{
    60		struct iattr *sd_iattr;
    61	
    62		sd_iattr = kzalloc(sizeof(struct iattr), GFP_KERNEL);
    63		if (!sd_iattr)
    64			return NULL;
    65		/* assign default attributes */
    66		sd_iattr->ia_mode = sd->s_mode;
    67		if (sd_parent && sd_parent->s_iattr) {
    68			sd_iattr->ia_uid = sd_parent->s_iattr->ia_uid;
    69			sd_iattr->ia_gid = sd_parent->s_iattr->ia_gid;
    70		} else {
    71			sd_iattr->ia_uid = GLOBAL_ROOT_UID;
    72			sd_iattr->ia_gid = GLOBAL_ROOT_GID;
    73		}
    74		sd_iattr->ia_atime = sd_iattr->ia_mtime =
  > 75				sd_iattr->ia_ctime = CURRENT_TIME;
    76		return sd_iattr;
    77	}
    78	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29326 bytes --]

      parent reply	other threads:[~2018-04-13 22:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07  3:36 [PATCH] configfs: initialize inode with owner Gwendal Grignou
2018-03-08  0:11 ` Gwendal Grignou
2018-04-13 10:51   ` [PATCH] configfs: inherit file and directory owners Gwendal Grignou
2018-04-13 21:01     ` kbuild test robot
2018-04-13 22:35     ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201804140544.s6smIrG9%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=drosen@google.com \
    --cc=gwendal@chromium.org \
    --cc=jlbec@evilplan.org \
    --cc=jorgelo@chromium.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).