From: Petr Mladek <pmladek@suse.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, "Jiri Kosina" <jikos@kernel.org>,
"Josh Poimboeuf" <jpoimboe@redhat.com>,
"Miroslav Benes" <mbenes@suse.cz>,
"Libor Pecháček" <lpechacek@suse.com>,
"Nicolai Stange" <nstange@suse.de>,
"Artem Savkov" <asavkov@redhat.com>
Subject: Re: [PATCH v3] selftests/livepatch: introduce tests
Date: Mon, 16 Apr 2018 14:49:47 +0200 [thread overview]
Message-ID: <20180416124947.4ehk7xbxoiqrklue@pathway.suse.cz> (raw)
In-Reply-To: <1523544871-29444-2-git-send-email-joe.lawrence@redhat.com>
On Thu 2018-04-12 10:54:31, Joe Lawrence wrote:
> Add a few livepatch modules and simple target modules that the included
> regression suite can run tests against.
>
>
> diff --git a/Documentation/livepatch/callbacks.txt b/Documentation/livepatch/callbacks.txt
> index c9776f48e458..6ca2801a6bb9 100644
> --- a/Documentation/livepatch/callbacks.txt
> +++ b/Documentation/livepatch/callbacks.txt
> @@ -116,490 +116,3 @@ virtnet_probe() initialized its driver's net_device features. A
It might make sense to add a note about sample modules in
lib/livepatch/
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 64155e310a9f..e4a0e81542ff 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1932,6 +1932,18 @@ config TEST_DEBUG_VIRTUAL
>
> If unsure, say N.
>
> +config TEST_LIVEPATCH
> + tristate "Test livepatching"
> + default n
> + depends on LIVEPATCH
> + depends on m
> + help
> + Test various kernel livepatching features for correctness.
> + The tests will load test modules that will be livepatched
> + in various scenarios.
It would be great to make a clue how to run the test. Something like:
To run tests call:
tools/testing/selftests/livepatch/test-callbacks.sh
tools/testing/selftests/livepatch/test-livepatch.sh
tools/selftests/livepatch/test-shadow-vars.sh
This is inspired by config TEST_KMOD description.
> + If unsure, say N.
> +
> endif # RUNTIME_TESTING_MENU
>
> config MEMTEST
> diff --git a/lib/Makefile b/lib/Makefile
> index a90d4fcd748f..98a38441afb0 100644
Otherwise, it looks great to me. Thanks a lot for getting this
together.
Best Regards,
Petr
next prev parent reply other threads:[~2018-04-16 12:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 14:54 [PATCH v3] Add livepatch kselftests Joe Lawrence
2018-04-12 14:54 ` [PATCH v3] selftests/livepatch: introduce tests Joe Lawrence
2018-04-12 21:36 ` Josh Poimboeuf
2018-04-13 11:20 ` Miroslav Benes
2018-04-13 20:52 ` Joe Lawrence
2018-04-16 11:33 ` Miroslav Benes
2018-04-16 15:02 ` Petr Mladek
2018-04-17 8:06 ` Miroslav Benes
2018-04-17 13:25 ` Joe Lawrence
2018-04-16 12:49 ` Petr Mladek [this message]
2018-04-20 12:56 ` Libor Pechacek
2018-04-23 14:43 ` Joe Lawrence
2018-04-24 15:50 ` Joe Lawrence
2018-04-24 17:19 ` Libor Pechacek
2018-04-24 17:35 ` Libor Pechacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416124947.4ehk7xbxoiqrklue@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=asavkov@redhat.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=lpechacek@suse.com \
--cc=mbenes@suse.cz \
--cc=nstange@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).