From: Jessica Yu <jeyu@kernel.org>
To: Jia Zhang <zhang.jia@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] module: Allow to always show the status of modsign
Date: Mon, 16 Apr 2018 17:51:05 +0200 [thread overview]
Message-ID: <20180416155105.vbog5ynqk2p2ogz3@redbean> (raw)
In-Reply-To: <1523418814-6857-2-git-send-email-zhang.jia@linux.alibaba.com>
+++ Jia Zhang [11/04/18 11:53 +0800]:
>The sig_enforce parameter could be always shown to reflect the
>current status of modsign. For the case of CONFIG_MODULE_SIG_FORCE=y,
>this modification does nothing harmless.
>
>Signed-off-by: Jia Zhang <zhang.jia@linux.alibaba.com>
Both patches look fine to me. Queued on modules-next.
Thanks,
Jessica
>---
> kernel/module.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/kernel/module.c b/kernel/module.c
>index f695474..1e3337b 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -274,9 +274,7 @@ static void module_assert_mutex_or_preempt(void)
> }
>
> static bool sig_enforce = IS_ENABLED(CONFIG_MODULE_SIG_FORCE);
>-#ifndef CONFIG_MODULE_SIG_FORCE
> module_param(sig_enforce, bool_enable_only, 0644);
>-#endif /* !CONFIG_MODULE_SIG_FORCE */
>
> /*
> * Export sig_enforce kernel cmdline parameter to allow other subsystems rely
>--
>1.8.3.1
>
prev parent reply other threads:[~2018-04-16 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 3:53 [PATCH 1/2] module: Do not access sig_enforce directly Jia Zhang
2018-04-11 3:53 ` [PATCH 2/2] module: Allow to always show the status of modsign Jia Zhang
2018-04-16 15:51 ` Jessica Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416155105.vbog5ynqk2p2ogz3@redbean \
--to=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).