From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752841AbeDRW2W (ORCPT ); Wed, 18 Apr 2018 18:28:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60976 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbeDRW2V (ORCPT ); Wed, 18 Apr 2018 18:28:21 -0400 Date: Wed, 18 Apr 2018 15:28:20 -0700 From: Andrew Morton To: Cyrill Gorcunov Cc: LKML , Michal Hocko , Randy Dunlap , Andrey Vagin , Andrew Morton , Pavel Emelyanov , Michael Kerrisk , Yang Shi Subject: Re: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations Message-Id: <20180418152820.e8f317534c01696d4835a40f@linux-foundation.org> In-Reply-To: <20180405182651.GM15783@uranus.lan> References: <20180405182651.GM15783@uranus.lan> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Apr 2018 21:26:51 +0300 Cyrill Gorcunov wrote: > Subject: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations s/Deprecate/remove/ ! > An ability to manipulate mm_struct fields was introduced in > sake of CRIU in first place. Later we provide more suitable > and safe operation PR_SET_MM_MAP where all fields to be modifed > are passed in one structure which allows us to make more detailed > verification. > > Still old interface remains present for compatibility reason > though CRIU itself already switched to PR_SET_MM_MAP on its > own long ago. > > Googling didn't reveal some other users of this operation > so I think it should be safe to remove this interface. It does seem a bit sudden. We could just add a "this interface is scheduled for removal" warning, then delete the code for real later in the year. To give people time to migrate or to complain to us.