From: "Raj, Ashok" <ashok.raj@intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: Vitezslav Samel <vitezslav@samel.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, x86-ml <x86@kernel.org>
Subject: Re: [PATCH 1/2] x86/microcode/intel: Save microcode patch unconditionally
Date: Fri, 20 Apr 2018 08:59:50 -0700 [thread overview]
Message-ID: <20180420155950.GA9792@araj-mobl1.jf.intel.com> (raw)
In-Reply-To: <20180420103428.GD13977@pd.tnic>
On Fri, Apr 20, 2018 at 12:34:28PM +0200, Borislav Petkov wrote:
> save_mc_for_early() was a no-op on !CONFIG_HOTPLUG_CPU but the
> generic_load_microcode() path saves the microcode patches it has found
> into our cache of patches which is used for late loading too. Regardless
> of whether we do CPU hotplug or not.
>
> So make the saving unconditional so that late loading can find the
> proper patch.
>
> Reported-by: Vitezslav Samel <vitezslav@samel.cz>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Ashok Raj <ashok.raj@intel.com>
Tested-by: Ashok Raj <ashok.raj@intel.com>
> Cc: <stable@vger.kernel.org> # if it has backported d8c3b52c00a05036e0a6b315b4b17921a7b67997
> Link: http://lkml.kernel.org/r/20180418081140.GA2439@pc11.op.pod.cz
> ---
next prev parent reply other threads:[~2018-04-20 15:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 8:11 4.15.17 regression: bisected: timeout during microcode update Vitezslav Samel
2018-04-18 10:07 ` Borislav Petkov
2018-04-18 12:08 ` Vitezslav Samel
2018-04-18 12:22 ` Borislav Petkov
2018-04-18 13:53 ` Raj, Ashok
2018-04-18 16:14 ` Borislav Petkov
2018-04-19 5:35 ` Vitezslav Samel
2018-04-19 7:22 ` Raj, Ashok
2018-04-19 10:48 ` Borislav Petkov
2018-04-19 12:02 ` Vitezslav Samel
2018-04-19 12:18 ` Borislav Petkov
2018-04-19 12:32 ` Raj, Ashok
2018-04-19 13:48 ` Vitezslav Samel
2018-04-19 13:46 ` Vitezslav Samel
2018-04-19 16:37 ` Borislav Petkov
2018-04-20 6:20 ` Vitezslav Samel
2018-04-20 9:52 ` Borislav Petkov
2018-04-20 10:01 ` Vitezslav Samel
2018-04-20 10:32 ` Borislav Petkov
2018-04-20 10:34 ` [PATCH 1/2] x86/microcode/intel: Save microcode patch unconditionally Borislav Petkov
2018-04-20 10:54 ` Vitezslav Samel
2018-04-20 15:59 ` Raj, Ashok [this message]
2018-04-20 10:37 ` [PATCH 2/2] x86/microcode: Do not exit early from __reload_late() Borislav Petkov
2018-04-20 10:54 ` Vitezslav Samel
2018-04-20 16:00 ` Raj, Ashok
2018-04-21 8:19 ` [PATCH 1/2] x86/microcode/intel: Save microcode patch unconditionally Borislav Petkov
2018-04-21 8:19 ` [PATCH 2/2] x86/microcode: Do not exit early from __reload_late() Borislav Petkov
2018-04-24 7:52 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
2018-04-24 7:51 ` [tip:x86/urgent] x86/microcode/intel: Save microcode patch unconditionally tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420155950.GA9792@araj-mobl1.jf.intel.com \
--to=ashok.raj@intel.com \
--cc=bp@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vitezslav@samel.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).