Hi Jerome, I love your patch! Yet something to improve: [auto build test ERROR on clk/clk-next] [also build test ERROR on v4.17-rc1 next-20180420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jerome-Brunet/clk-add-duty-cycle-support/20180421-021133 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: powerpc-ppc6xx_defconfig (attached as .config) compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=powerpc All errors (new ones prefixed by >>): #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) ^~~~~~~~~~~~~~~~~~~ include/trace/trace_events.h:399:6: note: in expansion of macro 'offsetof' offsetof(typeof(field), item), \ ^~~~~~~~ include/trace/trace_events.h:415:29: note: in expansion of macro '__field_ext' #define __field(type, item) __field_ext(type, item, FILTER_OTHER) ^~~~~~~~~~~ include/trace/events/clk.h:203:3: note: in expansion of macro '__field' __field( unsigned int, duty->num ) ^~~~~~~ include/trace/trace_events.h:400:18: error: 'struct trace_event_raw_clk_duty_cycle' has no member named 'duty' sizeof(field.item), \ ^ include/trace/trace_events.h:454:2: note: in definition of macro 'DECLARE_EVENT_CLASS' tstruct; \ ^~~~~~~ include/trace/events/clk.h:201:2: note: in expansion of macro 'TP_STRUCT__entry' TP_STRUCT__entry( ^~~~~~~~~~~~~~~~ include/trace/trace_events.h:415:29: note: in expansion of macro '__field_ext' #define __field(type, item) __field_ext(type, item, FILTER_OTHER) ^~~~~~~~~~~ include/trace/events/clk.h:203:3: note: in expansion of macro '__field' __field( unsigned int, duty->num ) ^~~~~~~ include/linux/compiler-gcc.h:166:2: error: 'struct trace_event_raw_clk_duty_cycle' has no member named 'duty' __builtin_offsetof(a, b) ^ include/trace/trace_events.h:454:2: note: in definition of macro 'DECLARE_EVENT_CLASS' tstruct; \ ^~~~~~~ include/trace/events/clk.h:201:2: note: in expansion of macro 'TP_STRUCT__entry' TP_STRUCT__entry( ^~~~~~~~~~~~~~~~ include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof' #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) ^~~~~~~~~~~~~~~~~~~ include/trace/trace_events.h:399:6: note: in expansion of macro 'offsetof' offsetof(typeof(field), item), \ ^~~~~~~~ include/trace/trace_events.h:415:29: note: in expansion of macro '__field_ext' #define __field(type, item) __field_ext(type, item, FILTER_OTHER) ^~~~~~~~~~~ include/trace/events/clk.h:204:3: note: in expansion of macro '__field' __field( unsigned int, duty->den ) ^~~~~~~ include/trace/trace_events.h:400:18: error: 'struct trace_event_raw_clk_duty_cycle' has no member named 'duty' sizeof(field.item), \ ^ include/trace/trace_events.h:454:2: note: in definition of macro 'DECLARE_EVENT_CLASS' tstruct; \ ^~~~~~~ include/trace/events/clk.h:201:2: note: in expansion of macro 'TP_STRUCT__entry' TP_STRUCT__entry( ^~~~~~~~~~~~~~~~ include/trace/trace_events.h:415:29: note: in expansion of macro '__field_ext' #define __field(type, item) __field_ext(type, item, FILTER_OTHER) ^~~~~~~~~~~ include/trace/events/clk.h:204:3: note: in expansion of macro '__field' __field( unsigned int, duty->den ) ^~~~~~~ In file included from include/trace/define_trace.h:96:0, from include/trace/events/clk.h:234, from drivers//clk/clk.c:84: include/trace/events/clk.h: In function 'trace_event_get_offsets_clk_duty_cycle': include/linux/compiler-gcc.h:166:2: error: 'struct trace_event_raw_clk_duty_cycle' has no member named '__data' __builtin_offsetof(a, b) ^ include/trace/trace_events.h:534:2: note: in definition of macro 'DECLARE_EVENT_CLASS' tstruct; \ ^~~~~~~ include/trace/events/clk.h:201:2: note: in expansion of macro 'TP_STRUCT__entry' TP_STRUCT__entry( ^~~~~~~~~~~~~~~~ include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof' #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) ^~~~~~~~~~~~~~~~~~~ include/trace/trace_events.h:494:11: note: in expansion of macro 'offsetof' offsetof(typeof(*entry), __data); \ ^~~~~~~~ include/trace/trace_events.h:499:29: note: in expansion of macro '__dynamic_array' #define __string(item, src) __dynamic_array(char, item, \ ^~~~~~~~~~~~~~~ include/trace/events/clk.h:202:3: note: in expansion of macro '__string' __string( name, core->name ) ^~~~~~~~ In file included from include/trace/define_trace.h:96:0, from include/trace/events/clk.h:234, from drivers//clk/clk.c:84: include/trace/events/clk.h: In function 'trace_event_raw_event_clk_duty_cycle': include/trace/events/clk.h:199:21: error: 'num' undeclared (first use in this function) TP_ARGS(core, num, den), ^ include/trace/trace_events.h:709:64: note: in definition of macro 'DECLARE_EVENT_CLASS' __data_size = trace_event_get_offsets_##call(&__data_offsets, args); \ ^~~~ include/trace/events/clk.h:199:7: note: in expansion of macro 'TP_ARGS' TP_ARGS(core, num, den), ^~~~~~~ >> include/trace/events/clk.h:199:26: error: 'den' undeclared (first use in this function); did you mean '_end'? TP_ARGS(core, num, den), ^ include/trace/trace_events.h:709:64: note: in definition of macro 'DECLARE_EVENT_CLASS' __data_size = trace_event_get_offsets_##call(&__data_offsets, args); \ ^~~~ include/trace/events/clk.h:199:7: note: in expansion of macro 'TP_ARGS' TP_ARGS(core, num, den), ^~~~~~~ include/trace/trace_events.h:709:16: error: too many arguments to function 'trace_event_get_offsets_clk_duty_cycle' __data_size = trace_event_get_offsets_##call(&__data_offsets, args); \ ^ include/trace/events/clk.h:195:1: note: in expansion of macro 'DECLARE_EVENT_CLASS' DECLARE_EVENT_CLASS(clk_duty_cycle, ^~~~~~~~~~~~~~~~~~~ In file included from include/trace/define_trace.h:96:0, from include/trace/events/clk.h:234, from drivers//clk/clk.c:84: include/trace/trace_events.h:527:27: note: declared here static inline notrace int trace_event_get_offsets_##call( \ ^ include/trace/events/clk.h:195:1: note: in expansion of macro 'DECLARE_EVENT_CLASS' DECLARE_EVENT_CLASS(clk_duty_cycle, ^~~~~~~~~~~~~~~~~~~ In file included from include/trace/define_trace.h:96:0, from include/trace/events/clk.h:234, from drivers//clk/clk.c:84: include/trace/events/clk.h:209:10: error: 'struct trace_event_raw_clk_duty_cycle' has no member named 'num' __entry->num = num; ^ include/trace/trace_events.h:719:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/clk.h:207:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ include/trace/events/clk.h:210:10: error: 'struct trace_event_raw_clk_duty_cycle' has no member named 'den' __entry->den = den; ^ include/trace/trace_events.h:719:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/clk.h:207:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ In file included from include/trace/define_trace.h:97:0, from include/trace/events/clk.h:234, from drivers//clk/clk.c:84: include/trace/events/clk.h: In function 'perf_trace_clk_duty_cycle': include/trace/events/clk.h:199:21: error: 'num' undeclared (first use in this function) TP_ARGS(core, num, den), ^ include/trace/perf.h:46:64: note: in definition of macro 'DECLARE_EVENT_CLASS' __data_size = trace_event_get_offsets_##call(&__data_offsets, args); \ ^~~~ include/trace/events/clk.h:199:7: note: in expansion of macro 'TP_ARGS' TP_ARGS(core, num, den), ^~~~~~~ >> include/trace/events/clk.h:199:26: error: 'den' undeclared (first use in this function); did you mean '_end'? TP_ARGS(core, num, den), ^ include/trace/perf.h:46:64: note: in definition of macro 'DECLARE_EVENT_CLASS' __data_size = trace_event_get_offsets_##call(&__data_offsets, args); \ ^~~~ include/trace/events/clk.h:199:7: note: in expansion of macro 'TP_ARGS' TP_ARGS(core, num, den), ^~~~~~~ include/trace/perf.h:46:16: error: too many arguments to function 'trace_event_get_offsets_clk_duty_cycle' __data_size = trace_event_get_offsets_##call(&__data_offsets, args); \ ^ include/trace/events/clk.h:195:1: note: in expansion of macro 'DECLARE_EVENT_CLASS' DECLARE_EVENT_CLASS(clk_duty_cycle, ^~~~~~~~~~~~~~~~~~~ In file included from include/trace/define_trace.h:96:0, from include/trace/events/clk.h:234, from drivers//clk/clk.c:84: include/trace/trace_events.h:527:27: note: declared here static inline notrace int trace_event_get_offsets_##call( \ ^ include/trace/events/clk.h:195:1: note: in expansion of macro 'DECLARE_EVENT_CLASS' DECLARE_EVENT_CLASS(clk_duty_cycle, ^~~~~~~~~~~~~~~~~~~ In file included from include/trace/define_trace.h:97:0, from include/trace/events/clk.h:234, from drivers//clk/clk.c:84: include/trace/events/clk.h:209:10: error: 'struct trace_event_raw_clk_duty_cycle' has no member named 'num' __entry->num = num; ^ include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/clk.h:207:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ include/trace/events/clk.h:210:10: error: 'struct trace_event_raw_clk_duty_cycle' has no member named 'den' __entry->den = den; ^ include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/clk.h:207:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ vim +199 include/trace/events/clk.h 196 197 TP_PROTO(struct clk_core *core, struct clk_duty *duty), 198 > 199 TP_ARGS(core, num, den), 200 201 TP_STRUCT__entry( 202 __string( name, core->name ) 203 __field( unsigned int, duty->num ) 204 __field( unsigned int, duty->den ) 205 ), 206 207 TP_fast_assign( 208 __assign_str(name, core->name); 209 __entry->num = num; 210 __entry->den = den; 211 ), 212 213 TP_printk("%s %u/%u", __get_str(name), (unsigned int)__entry->num, 214 (unsigned int)__entry->den) 215 ); 216 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation