From: Greg KH <gregkh@linuxfoundation.org>
To: Tom Hromatka <tom.hromatka@oracle.com>
Cc: davem@davemloft.net, sparclinux@vger.kernel.org, arnd@arndb.de,
linux-kernel@vger.kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, allen.pais@oracle.com,
khalid.aziz@oracle.com, shannon.nelson@oracle.com,
anthony.yznaga@oracle.com
Subject: Re: [PATCH v4 1/2] char: sparc64: Add privileged ADI driver
Date: Sat, 21 Apr 2018 11:04:49 +0200 [thread overview]
Message-ID: <20180421090449.GA8194@kroah.com> (raw)
In-Reply-To: <20180420205221.488589-2-tom.hromatka@oracle.com>
On Fri, Apr 20, 2018 at 02:52:20PM -0600, Tom Hromatka wrote:
> --- /dev/null
> +++ b/drivers/char/adi.c
> @@ -0,0 +1,240 @@
> +// SPDX-License-Identifier: GPL-2.0
Good, but:
> +MODULE_LICENSE("GPL");
That's the wrong line :(
Read include/linux/module.h for the correct string to put here for a
GPL version 2 only module.
thanks,
greg k-h
next prev parent reply other threads:[~2018-04-21 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 20:52 [PATCH v4 0/2] sparc64: Add privileged ADI driver Tom Hromatka
2018-04-20 20:52 ` [PATCH v4 1/2] char: " Tom Hromatka
2018-04-21 9:04 ` Greg KH [this message]
2018-04-22 21:52 ` Tom Hromatka
2018-04-20 20:52 ` [PATCH v4 2/2] selftests: sparc64: char: Selftest for " Tom Hromatka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180421090449.GA8194@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=allen.pais@oracle.com \
--cc=anthony.yznaga@oracle.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=khalid.aziz@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shannon.nelson@oracle.com \
--cc=shuah@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tom.hromatka@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).