From: Pavel Machek <pavel@ucw.cz>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
catalin.marinas@arm.com, cdall@kernel.org, drjones@redhat.com,
kvmarm@lists.cs.columbia.edu, linux-arch@vger.kernel.org,
ramana.radhakrishnan@arm.com, suzuki.poulose@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
awallis@codeaurora.org, kernel-hardening@lists.openwall.com
Subject: Re: [PATCHv3 11/11] arm64: docs: document pointer authentication
Date: Sun, 22 Apr 2018 11:00:03 +0200 [thread overview]
Message-ID: <20180422090003.GA24344@amd> (raw)
In-Reply-To: <86h8o3r5jy.wl-marc.zyngier@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]
On Sun 2018-04-22 09:47:29, Marc Zyngier wrote:
> On Sun, 22 Apr 2018 09:05:21 +0100,
> Pavel Machek wrote:
> >
> > Hi!
> >
> > > @@ -205,6 +205,14 @@ Before jumping into the kernel, the following conditions must be met:
> > > ICC_SRE_EL2.SRE (bit 0) must be initialised to 0b0.
> > > - The DT or ACPI tables must describe a GICv2 interrupt controller.
> > >
> > > + For CPUs with pointer authentication functionality:
> > > + - If EL3 is present:
> > > + SCR_EL3.APK (bit 16) must be initialised to 0b1
> > > + SCR_EL3.API (bit 17) must be initialised to 0b1
> > > + - If the kernel is entered at EL1:
> > > + HCR_EL2.APK (bit 40) must be initialised to 0b1
> > > + HCR_EL2.API (bit 41) must be initialised to 0b1
> > > +
> >
> > 0b1 is quite confusing way to write 1.
>
> Do you find 0x1 equally confusing?
It is slightly better. Still I'd not use it for describing single bit.
> 0bx is a pretty common way of describing bit-fields of a hardware
> register. It is also consistent with the rest of this document.
...and inconsistent with rest of the world :-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-04-22 9:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 18:37 [PATCHv3 00/11] ARMv8.3 pointer authentication userspace support Mark Rutland
2018-04-17 18:37 ` [PATCHv3 01/11] arm64: add pointer authentication register bits Mark Rutland
2018-04-17 18:37 ` [PATCHv3 02/11] arm64/kvm: consistently handle host HCR_EL2 flags Mark Rutland
2018-04-27 9:51 ` Christoffer Dall
2018-04-27 10:13 ` Mark Rutland
2018-04-17 18:37 ` [PATCHv3 03/11] arm64/kvm: hide ptrauth from guests Mark Rutland
2018-04-18 13:19 ` Andrew Jones
2018-04-18 13:47 ` Mark Rutland
2018-04-27 9:51 ` Christoffer Dall
2018-04-17 18:37 ` [PATCHv3 04/11] arm64: Don't trap host pointer auth use to EL2 Mark Rutland
2018-04-27 9:52 ` Christoffer Dall
2018-04-17 18:37 ` [PATCHv3 05/11] arm64/cpufeature: detect pointer authentication Mark Rutland
2018-04-17 18:37 ` [PATCHv3 06/11] asm-generic: mm_hooks: allow hooks to be overridden individually Mark Rutland
2018-04-17 19:56 ` Arnd Bergmann
2018-04-18 11:38 ` Mark Rutland
2018-04-17 18:37 ` [PATCHv3 07/11] arm64: add basic pointer authentication support Mark Rutland
2018-04-25 11:23 ` Catalin Marinas
2018-04-27 10:27 ` Mark Rutland
2018-04-17 18:37 ` [PATCHv3 08/11] arm64: expose user PAC bit positions via ptrace Mark Rutland
2018-04-17 18:37 ` [PATCHv3 09/11] arm64: perf: strip PAC when unwinding userspace Mark Rutland
2018-04-17 18:37 ` [PATCHv3 10/11] arm64: enable pointer authentication Mark Rutland
2018-04-17 18:37 ` [PATCHv3 11/11] arm64: docs: document " Mark Rutland
2018-04-22 8:05 ` Pavel Machek
2018-04-22 8:47 ` Marc Zyngier
2018-04-22 9:00 ` Pavel Machek [this message]
2018-04-25 12:27 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180422090003.GA24344@amd \
--to=pavel@ucw.cz \
--cc=arnd@arndb.de \
--cc=awallis@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=cdall@kernel.org \
--cc=drjones@redhat.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).