From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 1/9] perf check-headers.sh: Simplify arguments passing
Date: Mon, 23 Apr 2018 11:08:15 +0200 [thread overview]
Message-ID: <20180423090823.32309-2-jolsa@kernel.org> (raw)
In-Reply-To: <20180423090823.32309-1-jolsa@kernel.org>
Passing whole string instead of parsing them after.
It simplifies things for the next patches, that adds
another function call, which makes it hard to pass
arguments in the correct shape.
Link: http://lkml.kernel.org/n/tip-7sxkyhuktvxiepem60d6451b@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
| 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
--git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index 9aff89bc7535..88c5f9449809 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -59,13 +59,8 @@ check () {
file=$1
shift
- opts=
- while [ -n "$*" ]; do
- opts="$opts \"$1\""
- shift
- done
- cmd="diff $opts ../$file ../../$file > /dev/null"
+ cmd="diff $* ../$file ../../$file > /dev/null"
test -f ../../$file &&
eval $cmd || echo "Warning: Kernel ABI header at 'tools/$file' differs from latest version at '$file'" >&2
@@ -83,7 +78,7 @@ for i in $HEADERS; do
done
# diff with extra ignore lines
-check arch/x86/lib/memcpy_64.S -I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>"
-check arch/x86/lib/memset_64.S -I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>"
-check include/uapi/asm-generic/mman.h -I "^#include <\(uapi/\)*asm-generic/mman-common.h>"
-check include/uapi/linux/mman.h -I "^#include <\(uapi/\)*asm/mman.h>"
+check arch/x86/lib/memcpy_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>"'
+check arch/x86/lib/memset_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>"'
+check include/uapi/asm-generic/mman.h '-I "^#include <\(uapi/\)*asm-generic/mman-common.h>"'
+check include/uapi/linux/mman.h '-I "^#include <\(uapi/\)*asm/mman.h>"'
--
2.13.6
next prev parent reply other threads:[~2018-04-23 9:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 9:08 [PATCH 0/9] perf tools: Assorted fixes Jiri Olsa
2018-04-23 9:08 ` Jiri Olsa [this message]
2018-05-02 17:40 ` [tip:perf/core] perf check-headers.sh: Simplify arguments passing tip-bot for Jiri Olsa
2018-04-23 9:08 ` [PATCH 2/9] perf check-headers.sh: Add support to check 2 independent files Jiri Olsa
2018-04-23 14:28 ` Arnaldo Carvalho de Melo
2018-05-02 17:41 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-04-23 9:08 ` [PATCH 3/9] perf stat: Keep the / modifier separator in fallback Jiri Olsa
2018-04-23 14:16 ` Arnaldo Carvalho de Melo
2018-04-26 5:53 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-04-23 9:08 ` [PATCH 4/9] perf tools: Fix pmu events parsing rule Jiri Olsa
2018-04-23 14:20 ` Arnaldo Carvalho de Melo
2018-04-23 14:25 ` Jiri Olsa
2018-04-26 5:54 ` [tip:perf/urgent] perf pmu: " tip-bot for Jiri Olsa
2018-04-23 9:08 ` [PATCH 5/9] perf tools: Disable write_backward for leader sampling group events Jiri Olsa
2018-04-23 14:23 ` Arnaldo Carvalho de Melo
2018-04-26 5:54 ` [tip:perf/urgent] perf evsel: " tip-bot for Jiri Olsa
2018-04-23 9:08 ` [PATCH 6/9] perf stat: Display time in precision based on std deviation Jiri Olsa
2018-04-23 14:40 ` Arnaldo Carvalho de Melo
2018-05-02 17:41 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-04-23 9:08 ` [PATCH 7/9] perf stat: Add --table option to display time of each run Jiri Olsa
2018-04-23 14:41 ` Arnaldo Carvalho de Melo
2018-04-23 15:29 ` Jiri Olsa
2018-05-02 17:42 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-04-23 9:08 ` [PATCH 8/9] perf stat: Display length strings of each run for --table option Jiri Olsa
2018-05-02 17:42 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-04-23 9:08 ` [PATCH 9/9] perf stat: Display user and system time Jiri Olsa
2018-04-23 14:51 ` Arnaldo Carvalho de Melo
2018-04-23 15:30 ` Jiri Olsa
2018-04-23 18:48 ` [PATCH 0/9] perf tools: Assorted fixes Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423090823.32309-2-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).