From: Quentin Perret <quentin.perret@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org, c@hirez.programming.kicks-ass.net
Subject: Re: [PATCH] sched/fair: Rearrange select_task_rq_fair() to optimize it
Date: Wed, 25 Apr 2018 09:13:35 +0100 [thread overview]
Message-ID: <20180425081334.GF14391@e108498-lin.cambridge.arm.com> (raw)
In-Reply-To: <20180425051509.aohopadqw7q5urbd@vireshk-i7>
On Wednesday 25 Apr 2018 at 10:45:09 (+0530), Viresh Kumar wrote:
> On 24-04-18, 14:35, Peter Zijlstra wrote:
> > In any case, if there not going to be conflicts here, this all looks
> > good.
>
> Thanks Peter.
>
> I also had another patch and wasn't sure if that would be the right
> thing to do. The main purpose of this is to avoid calling
> sync_entity_load_avg() unnecessarily.
While you're at it, you could probably remove the one in wake_cap() ? I
think having just one in select_task_rq_fair() should be enough.
Thanks,
Quentin
next prev parent reply other threads:[~2018-04-25 8:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 10:38 [PATCH] sched/fair: Rearrange select_task_rq_fair() to optimize it Viresh Kumar
2018-04-24 10:02 ` Valentin Schneider
2018-04-24 10:30 ` Viresh Kumar
2018-04-24 10:43 ` Peter Zijlstra
2018-04-24 11:19 ` Valentin Schneider
2018-04-24 12:35 ` Peter Zijlstra
2018-04-24 15:46 ` Joel Fernandes
2018-04-24 15:47 ` Joel Fernandes
2018-04-24 22:34 ` Rohit Jain
2018-04-25 2:51 ` Viresh Kumar
2018-04-25 16:48 ` Rohit Jain
2018-04-25 5:15 ` Viresh Kumar
2018-04-25 8:13 ` Quentin Perret [this message]
2018-04-25 9:03 ` Viresh Kumar
2018-04-25 9:39 ` Quentin Perret
2018-04-25 10:13 ` Viresh Kumar
2018-04-25 10:55 ` Quentin Perret
2018-04-25 8:12 ` Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425081334.GF14391@e108498-lin.cambridge.arm.com \
--to=quentin.perret@arm.com \
--cc=c@hirez.programming.kicks-ass.net \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).