From: Lee Jones <lee.jones@linaro.org>
To: Javier Arteaga <javier@emutex.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"Dan O'Donovan" <dan@emutex.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH RESEND 3/3] pinctrl: upboard: Add UP2 pinctrl and gpio driver
Date: Thu, 26 Apr 2018 07:50:28 +0100 [thread overview]
Message-ID: <20180426065028.fvdf7ke5va2kacmv@dell> (raw)
In-Reply-To: <20180421085009.28773-4-javier@emutex.com>
On Sat, 21 Apr 2018, Javier Arteaga wrote:
> The UP2 board features a Raspberry Pi compatible pin header (HAT) and a
> board-specific expansion connector (EXHAT). Both expose assorted
> functions from either the SoC (such as GPIO, I2C, SPI, UART...) or other
> on-board devices (ADC, FPGA IP blocks...).
>
> These lines are routed through an on-board FPGA. The platform controller
> in its stock firmware provides register fields to change:
>
> - Line enable (FPGA pins enabled / high impedance)
> - Line direction (SoC driven / FPGA driven)
>
> To enable using SoC GPIOs on the pin header, this arrangement requires
> both configuring the platform controller, and updating the SoC pad
> registers in sync.
>
> Add a frontend pinctrl/GPIO driver that registers a new set of GPIO
> lines for the header pins. When these are requested, the driver
> propagates this request to the backend SoC pinctrl/GPIO driver by
> grabbing a GPIO descriptor for the matching SoC GPIO line. The needed
> mapping for this is retrieved via ACPI properties.
>
> Signed-off-by: Javier Arteaga <javier@emutex.com>
> ---
[...]
>
> drivers/mfd/upboard.c | 1 +
> drivers/pinctrl/Kconfig | 13 +
> drivers/pinctrl/Makefile | 1 +
> drivers/pinctrl/pinctrl-upboard.c | 523 ++++++++++++++++++++++++++++++
> 4 files changed, 538 insertions(+)
> create mode 100644 drivers/pinctrl/pinctrl-upboard.c
>
> diff --git a/drivers/mfd/upboard.c b/drivers/mfd/upboard.c
> index 6e4767e4dc41..35111981dfdf 100644
> --- a/drivers/mfd/upboard.c
> +++ b/drivers/mfd/upboard.c
> @@ -132,6 +132,7 @@ static struct upboard_led_data upboard_up2_led_data[] = {
> };
>
> static const struct mfd_cell upboard_up2_mfd_cells[] = {
> + { .name = "upboard-pinctrl" },
> UPBOARD_LED_CELL(upboard_up2_led_data, 0),
> UPBOARD_LED_CELL(upboard_up2_led_data, 1),
> UPBOARD_LED_CELL(upboard_up2_led_data, 2),
Please made this a separate patch.
There aren't any build dependencies between the files.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-04-26 6:50 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 8:50 [RFC PATCH RESEND 0/3] UP Squared board drivers Javier Arteaga
2018-04-21 8:50 ` [RFC PATCH RESEND 1/3] mfd: upboard: Add UP2 platform controller driver Javier Arteaga
2018-04-25 9:51 ` Mika Westerberg
2018-04-25 12:05 ` Javier Arteaga
2018-04-25 15:57 ` Andy Shevchenko
2018-04-26 2:33 ` Javier Arteaga
2018-04-21 8:50 ` [RFC PATCH RESEND 2/3] leds: upboard: Add LED support Javier Arteaga
2018-04-25 6:41 ` Pavel Machek
2018-04-25 7:02 ` Javier Arteaga
2018-04-25 7:04 ` Pavel Machek
2018-04-25 16:15 ` Andy Shevchenko
2018-04-26 2:34 ` Javier Arteaga
2018-04-26 7:55 ` Andy Shevchenko
2018-04-26 12:49 ` Javier Arteaga
2018-05-02 13:55 ` Andy Shevchenko
2018-04-26 7:34 ` Lee Jones
2018-04-26 13:03 ` Javier Arteaga
2018-04-27 7:38 ` Lee Jones
2018-04-21 8:50 ` [RFC PATCH RESEND 3/3] pinctrl: upboard: Add UP2 pinctrl and gpio driver Javier Arteaga
2018-04-25 16:49 ` Andy Shevchenko
2018-04-26 2:38 ` Javier Arteaga
2018-04-26 6:50 ` Lee Jones [this message]
2018-04-26 13:36 ` Javier Arteaga
2018-04-25 9:53 ` [RFC PATCH RESEND 0/3] UP Squared board drivers Mika Westerberg
2018-10-19 17:15 ` [PATCH v2 " Dan O'Donovan
2018-10-19 17:15 ` [PATCH v2 1/3] mfd: upboard: Add UP2 platform controller driver Dan O'Donovan
2018-10-20 11:49 ` Andy Shevchenko
2018-10-25 11:05 ` Lee Jones
2018-10-25 13:15 ` Andy Shevchenko
2018-10-31 20:40 ` Dan O'Donovan
2018-10-19 17:15 ` [PATCH v2 2/3] leds: upboard: Add LED support Dan O'Donovan
2018-10-20 11:17 ` Andy Shevchenko
2018-10-21 8:31 ` Pavel Machek
2018-10-23 18:50 ` Jacek Anaszewski
2018-10-23 18:54 ` Pavel Machek
2018-10-23 19:09 ` Jacek Anaszewski
2018-10-23 19:30 ` Pavel Machek
2018-10-24 20:07 ` Jacek Anaszewski
2018-10-25 9:22 ` Andy Shevchenko
2018-10-25 17:44 ` Jacek Anaszewski
2018-10-23 19:23 ` Joe Perches
2018-10-23 20:31 ` Jacek Anaszewski
2018-10-24 10:13 ` Andy Shevchenko
2018-10-24 10:24 ` Joe Perches
2018-10-19 17:15 ` [PATCH v2 3/3] pinctrl: upboard: Add UP2 pinctrl and gpio driver Dan O'Donovan
2018-10-20 11:40 ` Andy Shevchenko
2018-10-31 19:55 ` Dan O'Donovan
2018-10-22 9:07 ` Linus Walleij
2018-10-24 13:05 ` [PATCH v2 0/3] UP Squared board drivers Andy Shevchenko
2018-10-31 20:44 ` [PATCH v3 " Dan O'Donovan
2018-10-31 20:44 ` [PATCH v3 1/3] mfd: upboard: Add UP2 platform controller driver Dan O'Donovan
2018-11-01 8:07 ` Lee Jones
2018-11-01 9:58 ` Dan O'Donovan
2018-11-11 11:29 ` Pavel Machek
2018-11-15 14:56 ` Linus Walleij
2018-10-31 20:44 ` [PATCH v3 2/3] leds: upboard: Add LED support Dan O'Donovan
2018-10-31 20:44 ` [PATCH v3 3/3] pinctrl: upboard: Add UP2 pinctrl and gpio driver Dan O'Donovan
2018-10-31 21:30 ` Linus Walleij
2018-10-31 21:39 ` Dan O'Donovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426065028.fvdf7ke5va2kacmv@dell \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan@emutex.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jacek.anaszewski@gmail.com \
--cc=javier@emutex.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).