From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZq7MdD3K9/aQFtsu/So8Brvj8Zv7OcaBXk3FYkYLr0TSzKMYirN9huGu0S4XuEYZHSkIUci ARC-Seal: i=1; a=rsa-sha256; t=1524837687; cv=none; d=google.com; s=arc-20160816; b=LBlaMGJBLVItXaaqFvp00hfXPgwY54wja1N2QcFN+hhN1H7j9FAUSDFa4kyyOeJT3r GunhnxlBxEd3bpwzQmwBKFuZ21YXebbSc5/kqMq0VnLrT4vNcLLlMQSJE2z7/4mfCy9s 5bwUW6w/jyXgqbTO5yi0vzzYnmJn24boPUREclukLVRW0i1J6ExfjYvMkortlLgwhBwU OCmH15KiJX5oeFOn9OBYwErws4o5Zf3vLBkskaQHe2W3bNfQez4uycE/aenvnC6cfq3F 3p06k0dBZ3igZZJySCjzCwbiLjaUOdMM0M3Q8RzJjm5ycGWF5NKzycnd4nZNVhPWdu1E USiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:arc-authentication-results; bh=yE40rLSk+AKN3v6JFWNAbf6bhpNuVJVncts2gLLTWDI=; b=RTjaUV8LsXXA3K3eXolSY6z2ISURNl3fpN95DPevPYxdiSrRQFEhWsIKcT1vE87Dme V5pnzjvnhiKuOP91YbXVFXlT9KfmUU+v4shFdYc71OmvxOiNB6NFHx/h1hwHrN6ziid4 YEEFmZ7BXgTp1hi0RsiUKSw4yYphaKZ0EI1TNab54Oljhbg70G6XVIMFZvkPdrzM4BI4 OmgXQcHb0r98yfjcGLRbw4E3AmjI/AKJU0ApEfZjHnI/2yXUafRZakuXJ+FXNrQZyH88 Tu7HSjOVNIIBMewrBMkDYvxmpPgWwueYAPLOXgNgGhnraIP/ZCceVxGTnw9amkxwGD3B +PFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of srs0=4/0d=hq=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=4/0d=HQ=linuxfoundation.org=gregkh@kernel.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of srs0=4/0d=hq=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=4/0d=HQ=linuxfoundation.org=gregkh@kernel.org DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADD8321897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xin Long , "David S. Miller" Subject: [PATCH 4.4 28/50] bonding: do not set slave_dev npinfo before slave_enable_netpoll in bond_enslave Date: Fri, 27 Apr 2018 15:58:30 +0200 Message-Id: <20180427135657.368540468@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427135655.623669681@linuxfoundation.org> References: <20180427135655.623669681@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598908146234977294?= X-GMAIL-MSGID: =?utf-8?q?1598908202831425183?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xin Long [ Upstream commit ddea788c63094f7c483783265563dd5b50052e28 ] After Commit 8a8efa22f51b ("bonding: sync netpoll code with bridge"), it would set slave_dev npinfo in slave_enable_netpoll when enslaving a dev if bond->dev->npinfo was set. However now slave_dev npinfo is set with bond->dev->npinfo before calling slave_enable_netpoll. With slave_dev npinfo set, __netpoll_setup called in slave_enable_netpoll will not call slave dev's .ndo_netpoll_setup(). It causes that the lower dev of this slave dev can't set its npinfo. One way to reproduce it: # modprobe bonding # brctl addbr br0 # brctl addif br0 eth1 # ifconfig bond0 192.168.122.1/24 up # ifenslave bond0 eth2 # systemctl restart netconsole # ifenslave bond0 br0 # ifconfig eth2 down # systemctl restart netconsole The netpoll won't really work. This patch is to remove that slave_dev npinfo setting in bond_enslave(). Fixes: 8a8efa22f51b ("bonding: sync netpoll code with bridge") Signed-off-by: Xin Long Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/bonding/bond_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1614,8 +1614,7 @@ int bond_enslave(struct net_device *bond } /* switch(bond_mode) */ #ifdef CONFIG_NET_POLL_CONTROLLER - slave_dev->npinfo = bond->dev->npinfo; - if (slave_dev->npinfo) { + if (bond->dev->npinfo) { if (slave_enable_netpoll(new_slave)) { netdev_info(bond_dev, "master_dev is using netpoll, but new slave device does not support netpoll\n"); res = -EBUSY;