From: Mark Brown <broonie@kernel.org>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, perex@perex.cz,
tiwai@suse.com, dannenberg@ti.com, afd@ti.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ASoC: tas6424: Allow disabling auto diagnostics for faster power-on
Date: Fri, 27 Apr 2018 16:30:21 +0100 [thread overview]
Message-ID: <20180427153021.GE6872@sirena.org.uk> (raw)
In-Reply-To: <1524837349-16350-4-git-send-email-jjhiblot@ti.com>
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
On Fri, Apr 27, 2018 at 03:55:49PM +0200, Jean-Jacques Hiblot wrote:
> +static const char * const diags_enum_texts[] = {"OFF", "ON"};
> +static unsigned int diags_enum_values[] = {1, 0};
> +SOC_VALUE_ENUM_SINGLE_DECL(diags_enum, TAS6424_DC_DIAG_CTRL1,
> + TAS6424_LDGBYPASS_SHIFT, TAS6424_LDGBYPASS_MASK,
> + diags_enum_texts, diags_enum_values);
> +
This just just an on/off switch so it should be represented as a
standard _SINGLE() control with " Switch" at the end of the name so
userspace knows what to do with it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-04-27 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 13:55 [PATCH v2 0/3] ASoc: TAS6424: Add support for mute, standby, and faster power on Jean-Jacques Hiblot
2018-04-27 13:55 ` [PATCH v2 1/3] ASoC: tas6424: Add support for the standby pin Jean-Jacques Hiblot
2018-04-27 18:24 ` Applied "ASoC: tas6424: Add support for the standby pin" to the asoc tree Mark Brown
2018-04-27 20:13 ` [PATCH v2 1/3] ASoC: tas6424: Add support for the standby pin Rob Herring
2018-04-27 13:55 ` [PATCH v2 2/3] ASoC: tas6424: Add support for the mute pin Jean-Jacques Hiblot
2018-04-27 18:24 ` Applied "ASoC: tas6424: Add support for the mute pin" to the asoc tree Mark Brown
2018-04-27 20:15 ` [PATCH v2 2/3] ASoC: tas6424: Add support for the mute pin Rob Herring
2018-04-27 13:55 ` [PATCH v2 3/3] ASoC: tas6424: Allow disabling auto diagnostics for faster power-on Jean-Jacques Hiblot
2018-04-27 15:30 ` Mark Brown [this message]
2018-04-28 9:21 ` kbuild test robot
2018-04-28 9:21 ` [RFC PATCH] ASoC: tas6424: diags_enum can be static kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427153021.GE6872@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=dannenberg@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jjhiblot@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).