From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753019AbeD3JcM (ORCPT ); Mon, 30 Apr 2018 05:32:12 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:50922 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbeD3JcK (ORCPT ); Mon, 30 Apr 2018 05:32:10 -0400 X-Auth-Info: 9hhpsKVoxhcxYNP+NYtMGuX2eywsx9AP8a4W3AuspWw= Date: Mon, 30 Apr 2018 11:31:57 +0200 From: Lukasz Majewski To: Linus Walleij Cc: Ulf Hansson , "linux-kernel@vger.kernel.org" , Rob Herring , Mark Rutland , Adrian Hunter , Fabio Estevam , Wolfram Sang , Chanho Min , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-mmc , Stanislav Meduna Subject: Re: [PATCH] mmc: disable card sleep via device-tree Message-ID: <20180430113157.37a09e5c@jawa> In-Reply-To: References: <20180422213126.32756-1-lukma@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/GQcZcnqHsueOF9j.h1LrYQo"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/GQcZcnqHsueOF9j.h1LrYQo Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 30 Apr 2018 11:13:45 +0200 Hi Linus, > On Sun, Apr 22, 2018 at 11:31 PM, Lukasz Majewski > wrote: >=20 > > From: Stanislav Meduna > > > > On a TQMa53 module the mmc_sleep leaves the eMMC card in a state > > that the imx53 rom boot code is unable to probe, resulting in > > reboot hanging. Add a device tree property to disable sleeping > > on suspend. > > > > For TQMa53 modules the exact commit to cause hang after reboot > > (v3.10 -> v3.11): > > commit 486fdbbc1483 ("mmc: core: Add shutdown callback for (e)MMC > > bus_ops") > > > > [The exact discussion can be found here: > > https://patchwork.kernel.org/patch/8881401/ > > "i.MX53 restart via watchdog does not work" > > > > Signed-off-by: Stanislav Meduna > > Signed-off-by: Lukasz Majewski =20 > (...) >=20 > > Optional properties: > > -broken-hpi : Use this to indicate that the mmc-card has a broken > > hpi implementation, and that hpi should not be used > > +-no-sleep-on-suspend : Do not put the card to sleep when > > suspending. > > + There are boards with bootloaders that are unable > > + to probe such card when rebooting. =20 >=20 > As far as I understand this problem is not coming from the host > controller itself, > so it should not be tagged on to the host controller either. Rather > the problem is how the specific system has integrated the host > controller, the problem is in the fixture of this specific machine, > as you say, in the i.MX53 ROM. >=20 > In that case, I would say use this: >=20 > if (of_machine_is_compatible("fsl,imx53")) { > ..activate quirk... > } I see. Thanks for pointing this. >=20 > Yours, > Linus Walleij Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de --Sig_/GQcZcnqHsueOF9j.h1LrYQo Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAlrm4o0ACgkQAR8vZIA0 zr2sFQgAv82zj0TyT0DP6MwwHWZ27wU8H3GjV0n6w1jRM5g9btdBLTHC9aHPzG7G yIW0NNM8WSe29uDqd8THmfGrjbMtzdxa/1eAj3eQxtwJsKJd43w5KrZVmU8azPmk +kQkxLalkjDqkUsRv7CiTAPCn+OGVngaA8dcCvV1EvDBkzgCKBzfc7ahBj2TWcK6 3ejEbPNw8i9ujLP8qtRdpEUAOtJlYWNPG7U6n9ddtQCIQH0JZ8pU0+Ff0iAI7150 2nqPtmCyIlQUZYlIYslf2KG7PpH45lJ09uKu2tM7lpaiRBQnuG+nYf7dxsPfnage 8aVTBQyZZg1gDZ3q/OUvAqTRDZkYnw== =sbpo -----END PGP SIGNATURE----- --Sig_/GQcZcnqHsueOF9j.h1LrYQo--