From: Alex Williamson <alex.williamson@redhat.com>
To: "dongbo (E)" <dongbo4@huawei.com>
Cc: <corbet@lwn.net>, <kvm@vger.kernel.org>,
<linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] VFIO: Fix Documentation
Date: Mon, 30 Apr 2018 12:38:57 -0600 [thread overview]
Message-ID: <20180430123857.006a0697@w520.home> (raw)
In-Reply-To: <36f5940b-cac5-9a4a-86cb-7ad9766d5d62@huawei.com>
On Fri, 20 Apr 2018 18:07:27 +0800
"dongbo (E)" <dongbo4@huawei.com> wrote:
> From: Dong Bo <dongbo4@huawei.com>
>
> Signed-off-by: Dong Bo <dongbo4@huawei.com>
> ---
Hi Dong Bo,
The patch is corrupted, please resend and also include a commit log,
something as simple as "Update vfio_add_group_dev description to match
the current API" would be fine. Thanks,
Alex
> Documentation/vfio.txt | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt
> index ef6a511..f1a4d3c 100644
> --- a/Documentation/vfio.txt
> +++ b/Documentation/vfio.txt
> @@ -252,15 +252,14 @@ into VFIO core. When devices are bound and unbound to the driver,
> the driver should call vfio_add_group_dev() and vfio_del_group_dev()
> respectively::
> - extern int vfio_add_group_dev(struct iommu_group *iommu_group,
> - struct device *dev,
> + extern int vfio_add_group_dev(struct device *dev,
> const struct vfio_device_ops *ops,
> void *device_data);
> extern void *vfio_del_group_dev(struct device *dev);
> vfio_add_group_dev() indicates to the core to begin tracking the
> -specified iommu_group and register the specified dev as owned by
> +iommu_group of the specified dev and register the dev as owned by
> a VFIO bus driver. The driver provides an ops structure for callbacks
> similar to a file operations structure::
> -- 1.9.1
>
>
> .
>
>
next prev parent reply other threads:[~2018-04-30 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1524218521-61496-1-git-send-email-zhangshaokun@hisilicon.com>
2018-04-20 10:07 ` [PATCH] VFIO: Fix Documentation dongbo (E)
2018-04-30 18:38 ` Alex Williamson [this message]
2018-05-07 3:09 ` dongbo (E)
2018-05-07 3:02 [PATCH] vfio: fix documentation dongbo (E)
2018-05-07 7:53 ` Cornelia Huck
2018-05-08 15:17 ` Jonathan Corbet
-- strict thread matches above, loose matches on Subject: below --
2013-09-05 22:22 Zi Shen Lim
2013-09-05 22:39 ` Alex Williamson
2013-06-21 2:51 Alexey Kardashevskiy
2013-06-21 16:20 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430123857.006a0697@w520.home \
--to=alex.williamson@redhat.com \
--cc=corbet@lwn.net \
--cc=dongbo4@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).