From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, will.deacon@arm.com,
mpe@ellerman.id.au, bigeasy@linutronix.de, gkohli@codeaurora.org,
neeraju@codeaurora.org
Subject: Re: [PATCH 2/2] sched: Introduce set_special_state()
Date: Mon, 30 Apr 2018 18:45:46 +0200 [thread overview]
Message-ID: <20180430164545.GA10951@redhat.com> (raw)
In-Reply-To: <20180430142235.900370484@infradead.org>
On 04/30, Peter Zijlstra wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1968,7 +1968,7 @@ static void ptrace_stop(int exit_code, i
> * atomic with respect to siglock and should be done after the arch
> * hook as siglock is released and regrabbed across it.
> */
> - set_current_state(TASK_TRACED);
> + set_special_state(TASK_TRACED);
Yes, but please note the comment above, we need a barrier after state = TASK_TRACED,
that is why ptrace_stop() does set_current_state(), not __set_current_state().
Otherwise both patches look good to me, feel free to add
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2018-04-30 16:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 14:17 [PATCH 0/2] sched,kthread: Fix TASK_PARKED and special sleep states Peter Zijlstra
2018-04-30 14:17 ` [PATCH 1/2] kthread: Fix kthread_parkme() wait-loop Peter Zijlstra
2018-04-30 14:17 ` [PATCH 2/2] sched: Introduce set_special_state() Peter Zijlstra
2018-04-30 16:45 ` Oleg Nesterov [this message]
2018-04-30 19:40 ` Peter Zijlstra
2018-05-01 9:50 ` Peter Zijlstra
2018-05-01 13:59 ` Oleg Nesterov
2018-05-01 14:22 ` Peter Zijlstra
2018-05-01 15:10 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430164545.GA10951@redhat.com \
--to=oleg@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=gkohli@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=neeraju@codeaurora.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).