From: jacopo mondi <jacopo@jmondi.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: ysato@users.sourceforge.jp, dalias@libc.org,
thomas.petazzoni@free-electrons.com, robin.murphy@arm.com,
geert@linux-m68k.org, sergei.shtylyov@cogentembedded.com,
linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] sh: mm: Fix unprotected access to struct device
Date: Wed, 2 May 2018 09:46:31 +0200 [thread overview]
Message-ID: <20180502074600.GC27261@w540> (raw)
In-Reply-To: <1524044555-20610-1-git-send-email-jacopo+renesas@jmondi.org>
[-- Attachment #1: Type: text/plain, Size: 3034 bytes --]
Hi again Christoph,
The gentle ping actually applies to this version of the patch.
Sorry for the confusion.
Thanks
j
On Wed, Apr 18, 2018 at 11:42:35AM +0200, Jacopo Mondi wrote:
> With commit ce88313069c36eef80f21fd7 ("arch/sh: make the DMA mapping
> operations observe dev->dma_pfn_offset") the generic DMA allocation
> function on which the SH 'dma_alloc_coherent()' function relies on,
> accesses the 'dma_pfn_offset' field of struct device.
>
> Unfortunately the 'dma_generic_alloc_coherent()' function is called from
> several places with a NULL struct device argument, halting the CPU
> during the boot process.
>
> This patch fixes the issue by protecting access to dev->dma_pfn_offset,
> with a trivial check for validity. It also passes a valid 'struct device'
> in the 'platform_resource_setup_memory()' function which is the main user
> of 'dma_alloc_coherent()', and inserts a WARN_ON() check to remind to future
> (and existing) bogus users of this function to provide a valid 'struct device'
> whenever possible.
>
> Fixes: ce88313069c36eef80f21fd7 ("arch/sh: make the DMA mapping operations observe dev->dma_pfn_offset")
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> ---
> v2 -> v3:
> - remove (now) useless parenthesis around pfn assignement as suggested
> by Sergei
> - Add changelog to the patch, which I forgot in v2
>
> v1 -> v2:
> - Move WARN_ON() closer to dev validity check as suggested by Geert
>
> ---
> arch/sh/mm/consistent.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/sh/mm/consistent.c b/arch/sh/mm/consistent.c
> index 8ce9869..f1b4469 100644
> --- a/arch/sh/mm/consistent.c
> +++ b/arch/sh/mm/consistent.c
> @@ -59,7 +59,9 @@ void *dma_generic_alloc_coherent(struct device *dev, size_t size,
>
> split_page(pfn_to_page(virt_to_phys(ret) >> PAGE_SHIFT), order);
>
> - *dma_handle = virt_to_phys(ret) - PFN_PHYS(dev->dma_pfn_offset);
> + *dma_handle = virt_to_phys(ret);
> + if (!WARN_ON(!dev))
> + *dma_handle -= PFN_PHYS(dev->dma_pfn_offset);
>
> return ret_nocache;
> }
> @@ -69,9 +71,12 @@ void dma_generic_free_coherent(struct device *dev, size_t size,
> unsigned long attrs)
> {
> int order = get_order(size);
> - unsigned long pfn = (dma_handle >> PAGE_SHIFT) + dev->dma_pfn_offset;
> + unsigned long pfn = dma_handle >> PAGE_SHIFT;
> int k;
>
> + if (!WARN_ON(!dev))
> + pfn += dev->dma_pfn_offset;
> +
> for (k = 0; k < (1 << order); k++)
> __free_pages(pfn_to_page(pfn + k), 0);
>
> @@ -143,7 +148,7 @@ int __init platform_resource_setup_memory(struct platform_device *pdev,
> if (!memsize)
> return 0;
>
> - buf = dma_alloc_coherent(NULL, memsize, &dma_handle, GFP_KERNEL);
> + buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
> if (!buf) {
> pr_warning("%s: unable to allocate memory\n", name);
> return -ENOMEM;
> --
> 2.7.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2018-05-02 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 9:42 [PATCH v3] sh: mm: Fix unprotected access to struct device Jacopo Mondi
2018-05-02 7:46 ` jacopo mondi [this message]
2018-05-02 12:39 ` Christoph Hellwig
2018-05-03 7:15 ` jacopo mondi
2018-05-05 20:45 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502074600.GC27261@w540 \
--to=jacopo@jmondi.org \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).