From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Finn Thain <fthain@telegraphics.com.au>,
"David S. Miller" <davem@davemloft.net>,
linux-m68k <linux-m68k@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH net] macmace: Set platform device coherent_dma_mask
Date: Thu, 3 May 2018 10:51:20 +0200 [thread overview]
Message-ID: <20180503085120.GA14574@lst.de> (raw)
In-Reply-To: <CAMuHMdU1XBqt7hwEW6JTas64ZNGCGCMr5HMZwuLo0O-ZBCOWyA@mail.gmail.com>
On Thu, May 03, 2018 at 10:46:56AM +0200, Geert Uytterhoeven wrote:
> Perhaps you can add a new helper (platform_device_register_simple_dma()?)
> that takes the DMA mask, too?
> With people setting the mask to kill the WARNING splat, this may become
> more common.
>
> struct platform_device_info already has a dma_mask field, but
> platform_device_register_resndata() explicitly sets it to zero.
Yes, that would be useful. The other assumption could be that
platform devices always allow an all-0xff dma mask.
next prev parent reply other threads:[~2018-05-03 8:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S1751632AbeECEYA/20180503042400Z+254@vger.kernel.org>
2018-05-03 7:25 ` [PATCH net] macmace: Set platform device coherent_dma_mask Geert Uytterhoeven
2018-05-03 8:38 ` Finn Thain
2018-05-03 8:46 ` Geert Uytterhoeven
2018-05-03 8:51 ` Christoph Hellwig [this message]
2018-05-03 20:24 ` Michael Schmitz
2018-05-04 7:24 ` Geert Uytterhoeven
2018-05-04 8:16 ` Michael Schmitz
2018-05-10 1:25 ` Finn Thain
2018-05-10 1:25 ` Finn Thain
2018-05-10 20:27 ` Michael Schmitz
2018-05-10 23:55 ` Finn Thain
2018-05-11 2:11 ` Michael Schmitz
2018-05-11 3:28 ` Finn Thain
2018-05-11 4:18 ` Michael Schmitz
2018-05-11 5:28 ` Finn Thain
2018-05-11 9:30 ` Michael Schmitz
2018-05-11 10:06 ` Finn Thain
2018-05-11 22:02 ` Michael Schmitz
2018-05-03 4:23 Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503085120.GA14574@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).