From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751374AbeECO2b (ORCPT ); Thu, 3 May 2018 10:28:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:54976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbeECO21 (ORCPT ); Thu, 3 May 2018 10:28:27 -0400 Date: Thu, 3 May 2018 10:28:23 -0400 From: Steven Rostedt To: "Du, Changbin" Cc: Andrew Morton , yamada.masahiro@socionext.com, michal.lkml@markovi.net, tglx@linutronix.de, mingo@redhat.com, rdunlap@infradead.org, x86@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, arnd@arndb.de, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v2 4/5] kernel hacking: new config DEBUG_EXPERIENCE to apply GCC -Og optimization Message-ID: <20180503102823.5b54cd56@gandalf.local.home> In-Reply-To: <20180503134546.5p3z4g5na7ew4fun@intel.com> References: <1525268700-10631-1-git-send-email-changbin.du@intel.com> <1525268700-10631-5-git-send-email-changbin.du@intel.com> <20180502101707.206984e9@gandalf.local.home> <20180502134558.1f388e097dcde6f589635404@linux-foundation.org> <20180502211956.6c9e8d7b@vmware.local.home> <20180503134546.5p3z4g5na7ew4fun@intel.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 May 2018 21:45:46 +0800 "Du, Changbin" wrote: > > With that gcc comment, I still think CONFIG_OPTIMIZE_DEBUG is more > > inline with what it is and understandable than > > CONFIG_DEBUG_EXPERIENCE. The "OPTIMIZE" is the key word there. > > > > -- Steve > What about CONFIG_CC_OPTIMIZE_FOR_DEBUGGING? We alreay have > CONFIG_CC_OPTIMIZE_FOR_SIZE and CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE. Yes I like that much better. > > And do we need to move it to existing configuration menu "General setup-> > Compiler optimization level"? But I also want it appear in "kernel hacking" > since this is a debug option. I understand why you would want it by debugging, but I think it does make more sense to be included with the above two other options, as they are all mutually exclusive. This brings up the topic of creating config paradigms. That is, a way of saying "I want a debug kernel" and select one option that selects everything you would expect. Or perhaps we should have a: make debug_config that does it. But that's a different topic. For now, I would just included it in init/Kconfig, and not worry about it not showing up in kernel hacking. -- Steve