From: "'Antoine Tenart'" <antoine.tenart@bootlin.com>
To: David Laight <David.Laight@aculab.com>
Cc: "'Antoine Tenart'" <antoine.tenart@bootlin.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"nadavh@marvell.com" <nadavh@marvell.com>,
"oferh@marvell.com" <oferh@marvell.com>,
"igall@marvell.com" <igall@marvell.com>
Subject: Re: [PATCH 01/10] crypto: aead - allow to allocate AEAD requests on the stack
Date: Thu, 3 May 2018 14:23:30 +0200 [thread overview]
Message-ID: <20180503122330.GB3324@kwain> (raw)
In-Reply-To: <02ad9eb93c494314a85db69886cf787a@AcuMS.aculab.com>
Hi David,
On Wed, May 02, 2018 at 02:55:19PM +0000, David Laight wrote:
> From: Antoine Tenart
> >
> > +#define AEAD_REQUEST_ON_STACK(name, tfm) \
> > + char __##name##_desc[sizeof(struct aead_request) + \
> > + crypto_aead_reqsize(tfm)] CRYPTO_MINALIGN_ATTR; \
> > + struct aead_request *name = (void *)__##name##_desc
> > +
>
> This looks stunningly like a VLA.
I was expecting this question :) The thing is this define looks *a lot*
like the ones defined in other places in the crypto framework, such as
SKCIPHER_REQUEST_ON_STACK and AHASH_REQUEST_ON_STACK. Those haven't been
tackled down so far by the whole VLA removal so the idea was that the
same solution will apply to the 3 of them (and then I'm not really
adding a new one).
If you do have a suggestion on how to fix the 3 of them, I'll be glad to
make a patch for that, but I'm not sure there's an easy solution. And I
don't think I saw a patch on the mailing list about those defines.
Thanks,
Antoine
--
Antoine Ténart, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-03 12:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 9:57 [PATCH 00/10] crypto: inside-secure - AEAD support Antoine Tenart
2018-05-02 9:57 ` [PATCH 01/10] crypto: aead - allow to allocate AEAD requests on the stack Antoine Tenart
2018-05-02 14:55 ` David Laight
2018-05-03 12:23 ` 'Antoine Tenart' [this message]
2018-05-03 23:00 ` Herbert Xu
2018-05-04 7:18 ` 'Antoine Tenart'
2018-05-05 6:18 ` Herbert Xu
2018-05-05 17:17 ` 'Antoine Tenart'
2018-05-02 9:57 ` [PATCH 02/10] crypto: inside-secure - rework cipher functions for future AEAD support Antoine Tenart
2018-05-02 9:57 ` [PATCH 03/10] crypto: inside-secure - rework the alg type settings in the context Antoine Tenart
2018-05-02 9:57 ` [PATCH 04/10] crypto: inside-secure - make the context control size dynamic Antoine Tenart
2018-05-02 9:57 ` [PATCH 05/10] crypto: inside-secure - make the key and context size computation dynamic Antoine Tenart
2018-05-02 9:57 ` [PATCH 06/10] crypto: inside-secure - fix the hash then encrypt/decrypt types Antoine Tenart
2018-05-02 9:57 ` [PATCH 07/10] crypto: inside-secure - improve error reporting Antoine Tenart
2018-05-02 9:57 ` [PATCH 08/10] crypto: inside-secure - authenc(hmac(sha256),cbc(aes)) support Antoine Tenart
2018-05-02 9:57 ` [PATCH 09/10] crypto: inside-secure - authenc(hmac(sha224),cbc(aes)) support Antoine Tenart
2018-05-02 9:57 ` [PATCH 10/10] crypto: inside-secure - authenc(hmac(sha1),cbc(aes)) support Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503122330.GB3324@kwain \
--to=antoine.tenart@bootlin.com \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=herbert@gondor.apana.org.au \
--cc=igall@marvell.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=oferh@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).