From: kbuild test robot <lkp@intel.com>
To: Oza Pawandeep <poza@codeaurora.org>
Cc: kbuild-all@01.org, Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>,
Keith Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>,
Sinan Kaya <okaya@codeaurora.org>,
Timur Tabi <timur@codeaurora.org>,
Oza Pawandeep <poza@codeaurora.org>
Subject: Re: [PATCH v15 5/9] PCI/AER: Factor out error reporting from AER
Date: Fri, 4 May 2018 05:52:44 +0800 [thread overview]
Message-ID: <201805040533.5tfirf7A%fengguang.wu@intel.com> (raw)
In-Reply-To: <1525323838-1735-6-git-send-email-poza@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 3418 bytes --]
Hi Oza,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pci/next]
[also build test ERROR on v4.17-rc3 next-20180503]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180504-050017
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-x015-201817 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/pci/pcie/err.c: In function 'report_error_detected':
>> drivers/pci/pcie/err.c:98:3: error: implicit declaration of function 'pci_uevent_ers'; did you mean 'pci_select_bars'? [-Werror=implicit-function-declaration]
pci_uevent_ers(dev, PCI_ERS_RESULT_NONE);
^~~~~~~~~~~~~~
pci_select_bars
drivers/pci/pcie/err.c: In function 'reset_link':
drivers/pci/pcie/err.c:203:5: warning: 'driver' is used uninitialized in this function [-Wuninitialized]
if (driver && driver->reset_link) {
^
cc1: some warnings being treated as errors
vim +98 drivers/pci/pcie/err.c
52
53 static int report_error_detected(struct pci_dev *dev, void *data)
54 {
55 pci_ers_result_t vote;
56 const struct pci_error_handlers *err_handler;
57 struct aer_broadcast_data *result_data;
58
59 result_data = (struct aer_broadcast_data *) data;
60
61 device_lock(&dev->dev);
62 dev->error_state = result_data->state;
63
64 if (!dev->driver ||
65 !dev->driver->err_handler ||
66 !dev->driver->err_handler->error_detected) {
67 if (result_data->state == pci_channel_io_frozen &&
68 dev->hdr_type != PCI_HEADER_TYPE_BRIDGE) {
69 /*
70 * In case of fatal recovery, if one of down-
71 * stream device has no driver. We might be
72 * unable to recover because a later insmod
73 * of a driver for this device is unaware of
74 * its hw state.
75 */
76 pci_printk(KERN_DEBUG, dev, "device has %s\n",
77 dev->driver ?
78 "no AER-aware driver" : "no driver");
79 }
80
81 /*
82 * If there's any device in the subtree that does not
83 * have an error_detected callback, returning
84 * PCI_ERS_RESULT_NO_AER_DRIVER prevents calling of
85 * the subsequent mmio_enabled/slot_reset/resume
86 * callbacks of "any" device in the subtree. All the
87 * devices in the subtree are left in the error state
88 * without recovery.
89 */
90
91 if (dev->hdr_type != PCI_HEADER_TYPE_BRIDGE)
92 vote = PCI_ERS_RESULT_NO_AER_DRIVER;
93 else
94 vote = PCI_ERS_RESULT_NONE;
95 } else {
96 err_handler = dev->driver->err_handler;
97 vote = err_handler->error_detected(dev, result_data->state);
> 98 pci_uevent_ers(dev, PCI_ERS_RESULT_NONE);
99 }
100
101 result_data->result = merge_result(result_data->result, vote);
102 device_unlock(&dev->dev);
103 return 0;
104 }
105
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26139 bytes --]
next prev parent reply other threads:[~2018-05-03 21:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 5:03 [PATCH v15 0/9] Address error and recovery for AER and DPC Oza Pawandeep
2018-05-03 5:03 ` [PATCH v15 1/9] PCI: Unify wait for link active into generic PCI Oza Pawandeep
2018-05-10 13:18 ` Bjorn Helgaas
2018-05-03 5:03 ` [PATCH v15 2/9] pci-error-recovery: Add AER_FATAL handling Oza Pawandeep
2018-05-03 5:03 ` [PATCH v15 3/9] PCI/AER: Handle ERR_FATAL with removal and re-enumeration of devices Oza Pawandeep
2018-05-08 23:53 ` Bjorn Helgaas
2018-05-09 13:07 ` Bjorn Helgaas
2018-05-09 13:14 ` poza
2018-05-09 23:21 ` Bjorn Helgaas
2018-05-10 7:01 ` poza
2018-05-10 13:10 ` Bjorn Helgaas
2018-05-10 13:15 ` okaya
2018-05-10 14:18 ` poza
2018-05-10 13:17 ` Bjorn Helgaas
2018-05-03 5:03 ` [PATCH v15 4/9] PCI/AER: Rename error recovery to generic PCI naming Oza Pawandeep
2018-05-03 5:03 ` [PATCH v15 5/9] PCI/AER: Factor out error reporting from AER Oza Pawandeep
2018-05-03 21:52 ` kbuild test robot [this message]
2018-05-03 22:53 ` kbuild test robot
2018-05-04 6:48 ` poza
2018-05-03 5:03 ` [PATCH v15 6/9] PCI/PORTDRV: Implement generic find service Oza Pawandeep
2018-05-03 5:03 ` [PATCH v15 7/9] PCI/PORTDRV: Implement generic find device Oza Pawandeep
2018-05-10 13:31 ` Bjorn Helgaas
2018-05-03 5:03 ` [PATCH v15 8/9] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-05-10 13:22 ` Bjorn Helgaas
2018-05-10 14:26 ` poza
2018-05-10 16:27 ` Bjorn Helgaas
2018-05-03 5:03 ` [PATCH v15 9/9] PCI/DPC: Disable ERR_NONFATAL and enable ERR_FATAL for DPC Oza Pawandeep
2018-05-10 13:26 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201805040533.5tfirf7A%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
--cc=pombredanne@nexb.com \
--cc=poza@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).