* [PATCH REPOST] rbtree: include rcu.h because we use it
@ 2018-05-04 10:31 Sebastian Andrzej Siewior
2018-05-08 23:04 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-05-04 10:31 UTC (permalink / raw)
To: linux-kernel
Cc: tglx, Sebastian Andrzej Siewior, David Howells, Andrew Morton
Since commit c1adf20052d8 ("Introduce rb_replace_node_rcu()")
rbtree_augmented.h uses RCU related data structures but does not include
them. It works as long as gets somehow included before that and fails
otherwise.
Cc: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
include/linux/rbtree_augmented.h | 1 +
include/linux/rbtree_latch.h | 1 +
2 files changed, 2 insertions(+)
--- a/include/linux/rbtree_augmented.h
+++ b/include/linux/rbtree_augmented.h
@@ -26,6 +26,7 @@
#include <linux/compiler.h>
#include <linux/rbtree.h>
+#include <linux/rcupdate.h>
/*
* Please note - only struct rb_augment_callbacks and the prototypes for
--- a/include/linux/rbtree_latch.h
+++ b/include/linux/rbtree_latch.h
@@ -35,6 +35,7 @@
#include <linux/rbtree.h>
#include <linux/seqlock.h>
+#include <linux/rcupdate.h>
struct latch_tree_node {
struct rb_node node[2];
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH REPOST] rbtree: include rcu.h because we use it
2018-05-04 10:31 [PATCH REPOST] rbtree: include rcu.h because we use it Sebastian Andrzej Siewior
@ 2018-05-08 23:04 ` Andrew Morton
2018-05-09 21:55 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2018-05-08 23:04 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: linux-kernel, tglx, David Howells
On Fri, 4 May 2018 12:31:59 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> Since commit c1adf20052d8 ("Introduce rb_replace_node_rcu()")
> rbtree_augmented.h uses RCU related data structures but does not include
> them. It works as long as gets somehow included before that and fails
> otherwise.
c1adf20052d8 was two years ago. Are there any actual real build errors
arising from this? If so, backporting the patch might be needed?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH REPOST] rbtree: include rcu.h because we use it
2018-05-08 23:04 ` Andrew Morton
@ 2018-05-09 21:55 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-05-09 21:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, tglx, David Howells
On 2018-05-08 16:04:37 [-0700], Andrew Morton wrote:
> On Fri, 4 May 2018 12:31:59 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
>
> > Since commit c1adf20052d8 ("Introduce rb_replace_node_rcu()")
> > rbtree_augmented.h uses RCU related data structures but does not include
> > them. It works as long as gets somehow included before that and fails
> > otherwise.
>
> c1adf20052d8 was two years ago. Are there any actual real build errors
> arising from this? If so, backporting the patch might be needed?
I've seen them only in -RT. No backporting needed.
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-09 21:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04 10:31 [PATCH REPOST] rbtree: include rcu.h because we use it Sebastian Andrzej Siewior
2018-05-08 23:04 ` Andrew Morton
2018-05-09 21:55 ` Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).