From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbeEDQHd (ORCPT ); Fri, 4 May 2018 12:07:33 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:41570 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbeEDQHc (ORCPT ); Fri, 4 May 2018 12:07:32 -0400 Date: Fri, 4 May 2018 18:07:26 +0200 From: Sebastian Andrzej Siewior To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, Ingo Molnar , linux-mm@kvack.org, Shaohua Li , linux-raid@vger.kernel.org Subject: Re: Introduce atomic_dec_and_lock_irqsave() Message-ID: <20180504160726.ikotgmd5fbix7b6b@linutronix.de> References: <20180504154533.8833-1-bigeasy@linutronix.de> <20180504155446.GP12217@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180504155446.GP12217@hirez.programming.kicks-ass.net> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-05-04 17:54:46 [+0200], Peter Zijlstra wrote: > On Fri, May 04, 2018 at 05:45:28PM +0200, Sebastian Andrzej Siewior wrote: > > This series introduces atomic_dec_and_lock_irqsave() and converts a few > > users to use it. They were using local_irq_save() + > > atomic_dec_and_lock() before that series. > > Should not all these users be converted to refcount_t, and thus, should > we not introduce refcount_dec_and_lock_irqsave() instead? do you intend to kill refcount_dec_and_lock() in the longterm? I haz this but instead we do - atomic_dec_and_lock() -> refcount_dec_and_lock() - add refcount_dec_and_lock_irqsave() - patch 2+ use refcount_dec_and_lock_irqsave(). Sebastian