linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: adobriyan@gmail.com, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, mhocko@suse.com
Subject: Re: [PATCH] elf: don't hash userspace addresses
Date: Sat, 5 May 2018 09:31:50 +0900	[thread overview]
Message-ID: <201805050931.FEG18215.tFJOFLHOFVSOQM@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20180504212308.GA7564@avx2>

Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  fs/binfmt_elf.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -379,8 +379,8 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
>  
>  	if ((type & MAP_FIXED_NOREPLACE) &&
>  	    PTR_ERR((void *)map_addr) == -EEXIST)
> -		pr_info("%d (%s): Uhuuh, elf segment at %px requested but the memory is mapped already\n",
> -			task_pid_nr(current), current->comm, (void *)addr);
> +		pr_info("%d (%s): Uhuuh, elf segment at %lx requested but the memory is mapped already\n",
> +			task_pid_nr(current), current->comm, addr);

"%px" does not hash. For what reason you replace %px with %lx ?

>  
>  	return(map_addr);
>  }
> 

  reply	other threads:[~2018-05-05  0:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 21:23 [PATCH] elf: don't hash userspace addresses Alexey Dobriyan
2018-05-05  0:31 ` Tetsuo Handa [this message]
2018-05-05 12:32   ` Alexey Dobriyan
2018-05-05 13:19     ` Tetsuo Handa
2018-05-09 16:40       ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201805050931.FEG18215.tFJOFLHOFVSOQM@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).