From: Herbert Xu <herbert@gondor.apana.org.au>
To: NeilBrown <neilb@suse.com>
Cc: Thomas Graf <tgraf@suug.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Herbert <tom@quantonium.net>
Subject: Re: [PATCH 7/8] rhashtable: add rhashtable_walk_prev()
Date: Sat, 5 May 2018 17:43:25 +0800 [thread overview]
Message-ID: <20180505094324.wwjtl76oofgrtpg4@gondor.apana.org.au> (raw)
In-Reply-To: <152540605441.18473.4087381584733882012.stgit@noble>
On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote:
> rhashtable_walk_prev() returns the object returned by
> the previous rhashtable_walk_next(), providing it is still in the
> table (or was during this grace period).
> This works even if rhashtable_walk_stop() and rhashtable_talk_start()
> have been called since the last rhashtable_walk_next().
>
> If there have been no calls to rhashtable_walk_next(), or if the
> object is gone from the table, then NULL is returned.
>
> This can usefully be used in a seq_file ->start() function.
> If the pos is the same as was returned by the last ->next() call,
> then rhashtable_walk_prev() can be used to re-establish the
> current location in the table. If it returns NULL, then
> rhashtable_walk_next() should be used.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
I will ack this if Tom is OK with replacing peek with it.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-05-05 9:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 3:54 [PATCH 0/8] Assorted rhashtable fixes and cleanups NeilBrown
2018-05-04 3:54 ` [PATCH 8/8] rhashtable: don't hold lock on first table throughout insertion NeilBrown
2018-05-05 9:41 ` Herbert Xu
2018-05-05 22:00 ` NeilBrown
2018-05-06 5:20 ` Herbert Xu
2018-05-06 22:24 ` NeilBrown
2018-05-07 9:29 ` Herbert Xu
2018-05-08 0:23 ` NeilBrown
2018-05-04 3:54 ` [PATCH 6/8] rhashtable: further improve stability of rhashtable_walk NeilBrown
2018-05-05 9:42 ` Herbert Xu
2018-05-05 21:50 ` NeilBrown
2018-05-07 9:30 ` Herbert Xu
2018-05-08 0:54 ` NeilBrown
2018-05-04 3:54 ` [PATCH 1/8] rhashtable: silence RCU warning in rhashtable_test NeilBrown
2018-05-05 9:10 ` Herbert Xu
2018-05-05 21:49 ` NeilBrown
2018-05-04 3:54 ` [PATCH 2/8] rhashtable: remove nulls_base and related code NeilBrown
2018-05-05 9:12 ` Herbert Xu
2018-05-05 21:37 ` NeilBrown
2018-05-07 9:27 ` Herbert Xu
2018-05-08 1:14 ` NeilBrown
2018-05-04 3:54 ` [PATCH 5/8] rhashtable: remove rhashtable_walk_peek() NeilBrown
2018-05-05 9:30 ` Herbert Xu
2018-05-04 3:54 ` [PATCH 7/8] rhashtable: add rhashtable_walk_prev() NeilBrown
2018-05-05 9:43 ` Herbert Xu [this message]
2018-05-05 15:40 ` Tom Herbert
2018-05-06 22:16 ` NeilBrown
2018-05-04 3:54 ` [PATCH 4/8] rhashtable: fix race in nested_table_alloc() NeilBrown
2018-05-05 9:29 ` Herbert Xu
2018-05-05 21:48 ` NeilBrown
2018-05-06 5:18 ` Herbert Xu
2018-05-06 22:02 ` NeilBrown
2018-05-04 3:54 ` [PATCH 3/8] rhashtable: use cmpxchg() to protect ->future_tbl NeilBrown
2018-05-05 9:27 ` Herbert Xu
2018-05-05 21:45 ` NeilBrown
2018-05-04 17:07 ` [PATCH 0/8] Assorted rhashtable fixes and cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180505094324.wwjtl76oofgrtpg4@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).