From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751810AbeEEULN (ORCPT ); Sat, 5 May 2018 16:11:13 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:39437 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230AbeEEULM (ORCPT ); Sat, 5 May 2018 16:11:12 -0400 X-Google-Smtp-Source: AB8JxZr5giMTC3bQ+4rMno3a3g3QoOjAHsbdqSpEKbdBmt1I0TygIg3HNjR8aLtN+52X8secq7xTpw== From: Mathieu Malaterre To: Andrew Morton Cc: Mathieu Malaterre , Michal Hocko , Vlastimil Babka , Mel Gorman , Pavel Tatashin , Tetsuo Handa , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] =?UTF-8?q?mm:=20move=20function=20=E2=80=98is=5Fpageblock?= =?UTF-8?q?=5Fremovable=5Fnolock=E2=80=99=20inside=20blockers?= Date: Sat, 5 May 2018 22:11:06 +0200 Message-Id: <20180505201107.21070-1-malat@debian.org> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function ‘is_pageblock_removable_nolock’ is not used unless CONFIG_MEMORY_HOTREMOVE is activated. Move it in between #ifdef sentinel to match prototype in . Silence gcc warning (W=1): mm/page_alloc.c:7704:6: warning: no previous prototype for ‘is_pageblock_removable_nolock’ [-Wmissing-prototypes] Signed-off-by: Mathieu Malaterre --- mm/page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 905db9d7962f..94ca579938e5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7701,6 +7701,7 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count, return false; } +#ifdef CONFIG_MEMORY_HOTREMOVE bool is_pageblock_removable_nolock(struct page *page) { struct zone *zone; @@ -7723,6 +7724,7 @@ bool is_pageblock_removable_nolock(struct page *page) return !has_unmovable_pages(zone, page, 0, MIGRATE_MOVABLE, true); } +#endif #if (defined(CONFIG_MEMORY_ISOLATION) && defined(CONFIG_COMPACTION)) || defined(CONFIG_CMA) -- 2.11.0